firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Declare NavigationRailDestination.label as non-nullable (#77427)

Browse Source
This commit is contained in:
Jason Simmons 2021-03-08 12:54:03 -08:00 committed by GitHub
parent fd890292c5
commit 01776a3e5f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/flutter/lib/src/material/navigation_rail.dart
View File

@ -490,7 +490,7 @@ class _NavigationRailState extends State<NavigationRail> with TickerProviderStat
extendedTransitionAnimation: _extendedAnimation, extendedTransitionAnimation: _extendedAnimation,
selected: widget.selectedIndex == i, selected: widget.selectedIndex == i,
icon: widget.selectedIndex == i ? widget.destinations[i].selectedIcon : widget.destinations[i].icon, icon: widget.selectedIndex == i ? widget.destinations[i].selectedIcon : widget.destinations[i].icon,
label: widget.destinations[i].label!, label: widget.destinations[i].label,
destinationAnimation: _destinationAnimations[i], destinationAnimation: _destinationAnimations[i],
labelType: labelType, labelType: labelType,
iconTheme: widget.selectedIndex == i ? selectedIconTheme : unselectedIconTheme, iconTheme: widget.selectedIndex == i ? selectedIconTheme : unselectedIconTheme,
@ -818,10 +818,11 @@ class NavigationRailDestination {
const NavigationRailDestination({ const NavigationRailDestination({
required this.icon, required this.icon,
Widget? selectedIcon, Widget? selectedIcon,
this.label, required this.label,
this.padding, this.padding,
}) : selectedIcon = selectedIcon ?? icon, }) : selectedIcon = selectedIcon ?? icon,
assert(icon != null); assert(icon != null),
assert(label != null);
/// The icon of the destination. /// The icon of the destination.
/// ///
@ -856,7 +857,7 @@ class NavigationRailDestination {
/// [NavigationRail.labelType] is [NavigationRailLabelType.none], the label is /// [NavigationRail.labelType] is [NavigationRailLabelType.none], the label is
/// still used for semantics, and may still be used if /// still used for semantics, and may still be used if
/// [NavigationRail.extended] is true. /// [NavigationRail.extended] is true.
final Widget? label; final Widget label;
/// The amount of space to inset the destination item. /// The amount of space to inset the destination item.
final EdgeInsetsGeometry? padding; final EdgeInsetsGeometry? padding;