From 01f3d8fa67a93b0339e1266a6fc349062a15feea Mon Sep 17 00:00:00 2001 From: Hixie Date: Tue, 4 Nov 2014 11:57:02 -0800 Subject: [PATCH] Specs: define registerElement() more carefully; add an 'end tag parsed' callback; pass the element's module to the constructor when constructing a custom element (these are rather experimental changes and we may want to go a different way on this stuff) Review URL: https://codereview.chromium.org/701873004 --- examples/radio.sky | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/radio.sky b/examples/radio.sky index 36daa1c349..6cafa7199c 100644 --- a/examples/radio.sky +++ b/examples/radio.sky @@ -16,9 +16,9 @@ SKY MODULE - radio button and radio button group module.exports.RadioElement = module.registerElement({ tagName: 'radio', shadow: true, - prototype: class extends Element { - constructor () { - super(); + prototype: (class extends Element { + constructor (module) { + super(module); this.addEventListener('click', (event) => this.checked = true); this.shadowRoot.appendChild(module.document.findId('radio-shadow').content.cloneNode(true)); } @@ -42,7 +42,7 @@ SKY MODULE - radio button and radio button group if (this.parentNode instanceof module.exports.RadioGroupElement) this.parentNode.setChecked(this); } - }, + }).prototype, }); @@ -56,9 +56,9 @@ SKY MODULE - radio button and radio button group module.exports.RadioGroupElement = module.registerElement({ tagName: 'radiogroup', shadow: true, - prototype: class extends Element { - constructor () { - super(); + prototype: (class extends Element { + constructor (module) { + super(module); this.shadowRoot.appendChild(module.document.findId('radiogroup-shadow').content.cloneNode(true)); } get value () { @@ -85,6 +85,6 @@ SKY MODULE - radio button and radio button group if (child != radio) child.checked = false; } - }, + }).prototype, });