firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix some minor typos/grammar issues (#13230)

Browse Source
This commit is contained in:
Greg Spencer 2017-11-28 16:27:26 -08:00 committed by GitHub
parent fc2f3b4f0f
commit 02517b8b13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
packages/flutter/lib/src/rendering/object.dart
View File

@ -649,7 +649,7 @@ class PipelineOwner {
/// duplicate calls quickly. /// duplicate calls quickly.
final VoidCallback onNeedVisualUpdate; final VoidCallback onNeedVisualUpdate;
/// Called whenever this pipeline owner creates as semantics object. /// Called whenever this pipeline owner creates a semantics object.
/// ///
/// Typical implementations will schedule the creation of the initial /// Typical implementations will schedule the creation of the initial
/// semantics tree. /// semantics tree.
@ -703,7 +703,7 @@ class PipelineOwner {
Timeline.startSync('Layout', arguments: timelineWhitelistArguments); Timeline.startSync('Layout', arguments: timelineWhitelistArguments);
_debugDoingLayout = true; _debugDoingLayout = true;
try { try {
// TODO(ianh): assert that we're not allowing previously dirty nodes to redirty themeselves // TODO(ianh): assert that we're not allowing previously dirty nodes to redirty themselves
while (_nodesNeedingLayout.isNotEmpty) { while (_nodesNeedingLayout.isNotEmpty) {
final List<RenderObject> dirtyNodes = _nodesNeedingLayout; final List<RenderObject> dirtyNodes = _nodesNeedingLayout;
_nodesNeedingLayout = <RenderObject>[]; _nodesNeedingLayout = <RenderObject>[];
@ -797,8 +797,8 @@ class PipelineOwner {
/// The object that is managing semantics for this pipeline owner, if any. /// The object that is managing semantics for this pipeline owner, if any.
/// ///
/// An owner is created by [ensureSemantics]. The owner is valid for as long /// An owner is created by [ensureSemantics]. The owner is valid for as long
/// there are [SemanticsHandle] returned by [ensureSemantics] that have not /// there are [SemanticsHandle]s returned by [ensureSemantics] that have not
/// yet be disposed. Once the last handle has been disposed, the /// yet been disposed. Once the last handle has been disposed, the
/// [semanticsOwner] field will revert to null, and the previous owner will be /// [semanticsOwner] field will revert to null, and the previous owner will be
/// disposed. /// disposed.
/// ///
@ -972,7 +972,7 @@ class PipelineOwner {
/// ///
/// ### Layout interactions between render objects /// ### Layout interactions between render objects
/// ///
/// In general, the layout of a render box should only depend on the output of /// In general, the layout of a render object should only depend on the output of
/// its child's layout, and then only if `parentUsesSize` is set to true in the /// its child's layout, and then only if `parentUsesSize` is set to true in the
/// [layout] call. Furthermore, if it is set to true, the parent must call the /// [layout] call. Furthermore, if it is set to true, the parent must call the
/// child's [layout] if the child is to be rendered, because otherwise the /// child's [layout] if the child is to be rendered, because otherwise the
@ -1086,6 +1086,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
/// ///
/// Used in debug messages. /// Used in debug messages.
dynamic debugCreator; dynamic debugCreator;
void _debugReportException(String method, dynamic exception, StackTrace stack) { void _debugReportException(String method, dynamic exception, StackTrace stack) {
FlutterError.reportError(new FlutterErrorDetailsForRendering( FlutterError.reportError(new FlutterErrorDetailsForRendering(
exception: exception, exception: exception,

2
packages/flutter/lib/src/semantics/semantics.dart
View File

@ -1324,7 +1324,7 @@ class SemanticsConfiguration {
/// result in this configuration. /// result in this configuration.
/// ///
/// Only configurations that have [explicitChildNodes] set to false can /// Only configurations that have [explicitChildNodes] set to false can
/// absorb other configurations and its recommended to only absorb compatible /// absorb other configurations and it is recommended to only absorb compatible
/// configurations as determined by [isCompatibleWith]. /// configurations as determined by [isCompatibleWith].
void absorb(SemanticsConfiguration other) { void absorb(SemanticsConfiguration other) {
assert(!explicitChildNodes); assert(!explicitChildNodes);