From cf71fecf9db0a72d24cc8d8eb0c95daf39813871 Mon Sep 17 00:00:00 2001
From: Matt Perry <mpcomplete@chromium.org>
Date: Mon, 10 Aug 2015 16:22:57 -0400
Subject: [PATCH] Fix tab indicator animation so it doesn't snap to the
 previous tab.

If you tap multiple tabs in a row, the tab animation used to snap to the
last selected tab when starting a new animation. Fix that.

Also use the BuilderTransition so we don't have to rebuild the tab bar
every frame.
---
 packages/flutter/lib/widgets/tabs.dart | 43 +++++++++++---------------
 1 file changed, 18 insertions(+), 25 deletions(-)

diff --git a/packages/flutter/lib/widgets/tabs.dart b/packages/flutter/lib/widgets/tabs.dart
index 2cb2f4ee37..ef374abc09 100644
--- a/packages/flutter/lib/widgets/tabs.dart
+++ b/packages/flutter/lib/widgets/tabs.dart
@@ -21,6 +21,7 @@ import 'package:sky/widgets/icon.dart';
 import 'package:sky/widgets/ink_well.dart';
 import 'package:sky/widgets/scrollable.dart';
 import 'package:sky/widgets/theme.dart';
+import 'package:sky/widgets/transitions.dart';
 import 'package:sky/widgets/framework.dart';
 import 'package:vector_math/vector_math.dart';
 
@@ -425,26 +426,11 @@ class TabBar extends Scrollable {
     scrollBehavior.isScrollable = source.isScrollable;
   }
 
-  void didMount() {
-    _indicatorAnimation.addListener(_indicatorAnimationUpdated);
-    super.didMount();
-  }
-
-  void didUnmount() {
-    _indicatorAnimation.removeListener(_indicatorAnimationUpdated);
-    super.didUnmount();
-  }
-
-  void _indicatorAnimationUpdated() {
-    setState(() {
-    });
-  }
-
   AnimatedRect get _indicatorRect => _indicatorAnimation.variable as AnimatedRect;
 
   void _startIndicatorAnimation(int fromTabIndex, int toTabIndex) {
     _indicatorRect
-      ..begin = _tabIndicatorRect(fromTabIndex)
+      ..begin = (_indicatorRect.value == null ? _tabIndicatorRect(fromTabIndex) : _indicatorRect.value)
       ..end = _tabIndicatorRect(toTabIndex);
     _indicatorAnimation
       ..progress = 0.0
@@ -554,15 +540,22 @@ class TabBar extends Scrollable {
         data: new IconThemeData(color: iconThemeColor),
         child: new DefaultTextStyle(
           style: textStyle,
-          child: new TabBarWrapper(
-            children: tabs,
-            selectedIndex: selectedIndex,
-            backgroundColor: backgroundColor,
-            indicatorColor: indicatorColor,
-            indicatorRect: _indicatorRect.value,
-            textAndIcons: textAndIcons,
-            isScrollable: isScrollable,
-            onLayoutChanged: _layoutChanged
+          child: new BuilderTransition(
+            variables: [_indicatorRect],
+            direction: Direction.forward,
+            performance: _indicatorAnimation,
+            builder: () {
+              return new TabBarWrapper(
+                children: tabs,
+                selectedIndex: selectedIndex,
+                backgroundColor: backgroundColor,
+                indicatorColor: indicatorColor,
+                indicatorRect: _indicatorRect.value,
+                textAndIcons: textAndIcons,
+                isScrollable: isScrollable,
+                onLayoutChanged: _layoutChanged
+              );
+            }
           )
         )
       )