firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Upload logs before failing module_test_ios (#76341)

Browse Source
This commit is contained in:
Jenn Magder 2021-02-18 15:38:24 -08:00 committed by GitHub
parent 2659d6d18e
commit 050d49ae42
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 41 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
dev/devicelab/bin/tasks/module_test_ios.dart
View File

@ -295,49 +295,53 @@ Future<void> main() async {
section('Run platform unit tests'); section('Run platform unit tests');
final String resultBundleTemp = Directory.systemTemp.createTempSync('module_test_ios_xcresult.').path; final String resultBundleTemp = Directory.systemTemp.createTempSync('module_test_ios_xcresult.').path;
await testWithNewIOSSimulator('TestAdd2AppSim', (String deviceId) { await testWithNewIOSSimulator('TestAdd2AppSim', (String deviceId) async {
simulatorDeviceId = deviceId; simulatorDeviceId = deviceId;
final String resultBundlePath = path.join(resultBundleTemp, 'result'); final String resultBundlePath = path.join(resultBundleTemp, 'result');
return inDirectory(objectiveCHostApp, () => final int testResultExit = await exec(
exec( 'xcodebuild',
'xcodebuild',
<String>[
'-workspace',
'Host.xcworkspace',
'-scheme',
'Host',
'-configuration',
'Debug',
'-destination',
'id=$deviceId',
'-resultBundlePath',
resultBundlePath,
'test',
'CODE_SIGNING_ALLOWED=NO',
'CODE_SIGNING_REQUIRED=NO',
'CODE_SIGN_IDENTITY=-',
'EXPANDED_CODE_SIGN_IDENTITY=-',
'COMPILER_INDEX_STORE_ENABLE=NO',
],
));
}
);
// Zip the test results to the artifacts directory for upload.
await inDirectory(resultBundleTemp, () {
final String zipPath = path.join(hostAgent.dumpDirectory.path,
'module_test_ios-objc-${DateTime.now().toLocal().toIso8601String()}.zip');
return exec(
'zip',
<String>[ <String>[
'-r', '-workspace',
'-9', 'Host.xcworkspace',
zipPath, '-scheme',
'result.xcresult', 'Host',
'-configuration',
'Debug',
'-destination',
'id=$deviceId',
'-resultBundlePath',
resultBundlePath,
'test',
'CODE_SIGNING_ALLOWED=NO',
'CODE_SIGNING_REQUIRED=NO',
'CODE_SIGN_IDENTITY=-',
'EXPANDED_CODE_SIGN_IDENTITY=-',
'COMPILER_INDEX_STORE_ENABLE=NO',
], ],
canFail: true, // Best effort to get the logs. workingDirectory: objectiveCHostApp.path,
canFail: true,
); );
if (testResultExit != 0) {
// Zip the test results to the artifacts directory for upload.
await inDirectory(resultBundleTemp, () {
final String zipPath = path.join(hostAgent.dumpDirectory.path,
'module_test_ios-objc-${DateTime.now().toLocal().toIso8601String()}.zip');
return exec(
'zip',
<String>[
'-r',
'-9',
zipPath,
'result.xcresult',
],
canFail: true, // Best effort to get the logs.
);
});
throw TaskResult.failure('Platform unit tests failed');
}
}); });
section('Fail building existing Objective-C iOS app if flutter script fails'); section('Fail building existing Objective-C iOS app if flutter script fails');