firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename DeviceGestureSettings.fromWindow to DeviceGestureSettings.fromView (#119291)

Browse Source
This commit is contained in:
Michael Goderbauer 2023-01-26 16:34:39 -08:00 committed by GitHub
parent 4aed487ca5
commit 05fc29fe71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter/lib/src/gestures/gesture_settings.dart
View File

@ -24,11 +24,11 @@ class DeviceGestureSettings {
this.touchSlop, this.touchSlop,
}); });
/// Create a new [DeviceGestureSettings] from the provided [window]. /// Create a new [DeviceGestureSettings] from the provided [view].
factory DeviceGestureSettings.fromWindow(ui.FlutterView window) { factory DeviceGestureSettings.fromView(ui.FlutterView view) {
final double? physicalTouchSlop = window.viewConfiguration.gestureSettings.physicalTouchSlop; final double? physicalTouchSlop = view.viewConfiguration.gestureSettings.physicalTouchSlop;
return DeviceGestureSettings( return DeviceGestureSettings(
touchSlop: physicalTouchSlop == null ? null : physicalTouchSlop / window.devicePixelRatio touchSlop: physicalTouchSlop == null ? null : physicalTouchSlop / view.devicePixelRatio
); );
} }

2
packages/flutter/lib/src/widgets/media_query.dart
View File

@ -219,7 +219,7 @@ class MediaQueryData {
highContrast = platformData?.highContrast ?? view.platformDispatcher.accessibilityFeatures.highContrast, highContrast = platformData?.highContrast ?? view.platformDispatcher.accessibilityFeatures.highContrast,
alwaysUse24HourFormat = platformData?.alwaysUse24HourFormat ?? view.platformDispatcher.alwaysUse24HourFormat, alwaysUse24HourFormat = platformData?.alwaysUse24HourFormat ?? view.platformDispatcher.alwaysUse24HourFormat,
navigationMode = platformData?.navigationMode ?? NavigationMode.traditional, navigationMode = platformData?.navigationMode ?? NavigationMode.traditional,
gestureSettings = DeviceGestureSettings.fromWindow(view), gestureSettings = DeviceGestureSettings.fromView(view),
displayFeatures = view.displayFeatures; displayFeatures = view.displayFeatures;
/// The size of the media in logical pixels (e.g, the size of the screen). /// The size of the media in logical pixels (e.g, the size of the screen).

8
packages/flutter/test/widgets/media_query_test.dart
View File

@ -200,7 +200,7 @@ void main() {
expect(data.highContrast, platformData.highContrast); expect(data.highContrast, platformData.highContrast);
expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat); expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat);
expect(data.navigationMode, platformData.navigationMode); expect(data.navigationMode, platformData.navigationMode);
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view)); expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
expect(data.displayFeatures, view.displayFeatures); expect(data.displayFeatures, view.displayFeatures);
}); });
@ -240,7 +240,7 @@ void main() {
expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast); expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast);
expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat); expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat);
expect(data.navigationMode, NavigationMode.traditional); expect(data.navigationMode, NavigationMode.traditional);
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view)); expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
expect(data.displayFeatures, view.displayFeatures); expect(data.displayFeatures, view.displayFeatures);
}); });
@ -296,7 +296,7 @@ void main() {
expect(data.highContrast, platformData.highContrast); expect(data.highContrast, platformData.highContrast);
expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat); expect(data.alwaysUse24HourFormat, platformData.alwaysUse24HourFormat);
expect(data.navigationMode, platformData.navigationMode); expect(data.navigationMode, platformData.navigationMode);
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view)); expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
expect(data.displayFeatures, view.displayFeatures); expect(data.displayFeatures, view.displayFeatures);
}); });
@ -354,7 +354,7 @@ void main() {
expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast); expect(data.highContrast, platformDispatcher.accessibilityFeatures.highContrast);
expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat); expect(data.alwaysUse24HourFormat, platformDispatcher.alwaysUse24HourFormat);
expect(data.navigationMode, NavigationMode.traditional); expect(data.navigationMode, NavigationMode.traditional);
expect(data.gestureSettings, DeviceGestureSettings.fromWindow(view)); expect(data.gestureSettings, DeviceGestureSettings.fromView(view));
expect(data.displayFeatures, view.displayFeatures); expect(data.displayFeatures, view.displayFeatures);
}); });