firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clean up stale or unnecessary TODOS (#88308)

Browse Source
This commit is contained in:
Jonah Williams 2021-08-16 21:37:03 -07:00 committed by GitHub
parent d39d542691
commit 060e4608b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
15 changed files with 16 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev/devicelab/lib/tasks/web_dev_mode_tests.dart
View File

@ -21,7 +21,6 @@ const String kFirstRecompileTime = 'FirstRecompileTime';
const String kSecondStartupTime = 'SecondStartupTime';
const String kSecondRestartTime = 'SecondRestartTime';
abstract class WebDevice {
static const String chrome = 'chrome';
static const String webServer = 'web-server';
@ -61,7 +60,8 @@ TaskFunction createWebDevModeTest(String webDevice, bool enableIncrementalCompil
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
// TODO(jonahwilliams): non-dwds builds do not know when the browser is loaded.
// non-dwds builds do not know when the browser is loaded so keep trying
// until this succeeds.
if (line.contains('Ignoring terminal input')) {
Future<void>.delayed(const Duration(seconds: 1)).then((void _) {
process.stdin.write(restarted ? 'q' : 'r');
@ -139,7 +139,8 @@ TaskFunction createWebDevModeTest(String webDevice, bool enableIncrementalCompil
.transform<String>(utf8.decoder)
.transform<String>(const LineSplitter())
.listen((String line) {
// TODO(jonahwilliams): non-dwds builds do not know when the browser is loaded.
// non-dwds builds do not know when the browser is loaded so keep trying
// until this succeeds.
if (line.contains('Ignoring terminal input')) {
Future<void>.delayed(const Duration(seconds: 1)).then((void _) {
process.stdin.write(restarted ? 'q' : 'r');

4
packages/flutter/lib/src/animation/animation_controller.dart
View File

@ -572,7 +572,9 @@ class AnimationController extends Animation<double>
case AnimationBehavior.normal:
// Since the framework cannot handle zero duration animations, we run it at 5% of the normal
// duration to limit most animations to a single frame.
// TODO(jonahwilliams): determine a better process for setting duration.
// Ideally, the framework would be able to handle zero duration animations, however, the common
// pattern of an eternally repeating animation might cause an endless loop if it weren't delayed
// for at least one frame.
scale = 0.05;
break;
case AnimationBehavior.preserve:

2
packages/flutter_test/lib/src/_goldens_io.dart
View File

@ -143,7 +143,7 @@ mixin LocalComparisonOutput {
String additionalFeedback = '';
if (result.diffs != null) {
additionalFeedback = '\nFailure feedback can be found at ${path.join(basedir.path, 'failures')}';
final Map<String, Image> diffs = result.diffs!.cast<String, Image>();
final Map<String, Image> diffs = result.diffs!;
for (final MapEntry<String, Image> entry in diffs.entries) {
final File output = getFailureFile(
key.isEmpty ? entry.key : '${entry.key}_$key',

4
packages/flutter_test/lib/src/goldens.dart
View File

@ -3,6 +3,7 @@
// found in the LICENSE file.
import 'dart:typed_data';
import 'dart:ui';
import 'package:path/path.dart' as path;
import '_goldens_io.dart' if (dart.library.html) '_goldens_web.dart' as _goldens;
@ -326,8 +327,7 @@ class ComparisonResult {
/// Map containing differential images to illustrate found variants in pixel
/// values in the execution of the pixel test.
// TODO(jonahwilliams): fix type signature when image is updated to support web.
final Map<String, Object>? diffs;
final Map<String, Image>? diffs;
/// The calculated percentage of pixel difference between two images.
final double diffPercent;

4
packages/flutter_tools/bin/fuchsia_attach.dart
View File

@ -55,7 +55,7 @@ Future<void> main(List<String> args) async {
final String packages = '$buildDirectory/dartlang/gen/$path/${name}_dart_library.packages';
final String outputDill = '$buildDirectory/${name}_tmp.dill';
// TODO(jonahwilliams): running from fuchsia root hangs hot reload for some reason.
// Running from fuchsia root hangs hot reload for some reason.
// switch to the project root directory and run from there.
originalWorkingDirectory = globals.fs.currentDirectory.path;
globals.fs.currentDirectory = path;
@ -92,7 +92,7 @@ Future<void> main(List<String> args) async {
'--target',
targetFile,
'--target-model',
'flutter', // TODO(jonahwilliams): change to flutter_runner when dart SDK rolls
'flutter_runner',
'--output-dill',
outputDill,
'--packages',

2
packages/flutter_tools/lib/src/build_system/build_system.dart
View File

@ -605,7 +605,7 @@ class FlutterBuildSystem extends BuildSystem {
// Always persist the file cache to disk.
fileCache.persist();
}
// TODO(jonahwilliams): this is a bit of a hack, due to various parts of
// This is a bit of a hack, due to various parts of
// the flutter tool writing these files unconditionally. Since Xcode uses
// timestamps to track files, this leads to unnecessary rebuilds if they
// are included. Once all the places that write these files have been

3
packages/flutter_tools/lib/src/build_system/targets/localizations.dart
View File

@ -23,9 +23,6 @@ class GenerateLocalizationsTarget extends Target {
List<Source> get inputs => <Source>[
// This is added as a convenience for developing the tool.
const Source.pattern('{FLUTTER_ROOT}/packages/flutter_tools/lib/src/build_system/targets/localizations.dart'),
// TODO(jonahwilliams): once https://github.com/flutter/flutter/issues/56321 is
// complete, we should add the artifact as a dependency here. Since the tool runs
// this code from source, looking up each dependency will be cumbersome.
];
@override

4
packages/flutter_tools/lib/src/commands/create_base.dart
View File

@ -371,9 +371,7 @@ abstract class CreateBase extends FlutterCommand {
'pluginClassSnakeCase': pluginClassSnakeCase,
'pluginClassCapitalSnakeCase': pluginClassCapitalSnakeCase,
'pluginDartClass': pluginDartClass,
// TODO(jonahwilliams): update after google3 uuid is updated.
// ignore: prefer_const_constructors
'pluginProjectUUID': Uuid().v4().toUpperCase(),
'pluginProjectUUID': const Uuid().v4().toUpperCase(),
'withPluginHook': withPluginHook,
'androidLanguage': androidLanguage,
'iosLanguage': iosLanguage,

3
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
View File

@ -740,9 +740,6 @@ class FuchsiaDevice extends Device {
/// provided set of `ports`.
///
/// Returns null if no isolate port can be found.
///
// TODO(jonahwilliams): replacing this with the hub will require an update
// to the flutter_runner.
Future<int> findIsolatePort(String isolateName, List<int> ports) async {
for (final int port in ports) {
try {

1
packages/flutter_tools/lib/src/mdns_discovery.dart
View File

@ -58,7 +58,6 @@ class MDnsObservatoryDiscovery {
/// If it is null and there is only one available instance of Observatory,
/// it will return that instance's information regardless of what application
/// the Observatory instance is for.
// TODO(jonahwilliams): use `deviceVmservicePort` to filter mdns results.
@visibleForTesting
Future<MDnsObservatoryDiscoveryResult> query({String applicationId, int deviceVmservicePort}) async {
_logger.printTrace('Checking for advertised Dart observatories...');

2
packages/flutter_tools/lib/src/test/runner.dart
View File

@ -155,8 +155,6 @@ class _FlutterTestRunnerImpl implements FlutterTestRunner {
testWrapper.registerPlatformPlugin(
<Runtime>[Runtime.chrome],
() {
// TODO(jonahwilliams): refactor this into a factory that handles
// providing dependencies.
return FlutterWebPlatform.start(
flutterProject.directory.path,
updateGoldens: updateGoldens,

3
packages/flutter_tools/lib/src/tester/flutter_tester.dart
View File

@ -54,9 +54,6 @@ class FlutterTesterDevice extends Device {
@required ProcessManager processManager,
@required FlutterVersion flutterVersion,
@required Logger logger,
// TODO(jonahwilliams): remove once g3 rolls.
// ignore: avoid_unused_constructor_parameters
String buildDirectory,
@required FileSystem fileSystem,
@required Artifacts artifacts,
@required OperatingSystemUtils operatingSystemUtils,

1
packages/flutter_tools/lib/src/web/bootstrap.dart
View File

@ -129,7 +129,6 @@ String generateMainModule({
required bool nativeNullAssertions,
String bootstrapModule = 'main_module.bootstrap',
}) {
// TODO(jonahwilliams): fix typo in dwds and update.
return '''
/* ENTRYPOINT_EXTENTION_MARKER */
// Create the main module loaded below.

4
packages/flutter_tools/lib/src/web/web_device.dart
View File

@ -57,8 +57,8 @@ abstract class ChromiumDevice extends Device {
/// The active chrome instance.
Chromium _chrome;
// TODO(jonahwilliams): this is technically false, but requires some refactoring
// to allow hot mode restart only devices.
// This device does not actually support hot reload, but the current implementation of the resident runner
// requires both supportsHotReload and supportsHotRestart to be true in order to allow hot restart.
@override
bool get supportsHotReload => true;

1
packages/flutter_tools/test/general.shard/tester/flutter_tester_test.dart
View File

@ -96,7 +96,6 @@ void main() {
fileSystem: fileSystem,
processManager: fakeProcessManager,
artifacts: Artifacts.test(),
buildDirectory: 'build',
logger: BufferLogger.test(),
flutterVersion: FakeFlutterVersion(),
operatingSystemUtils: FakeOperatingSystemUtils(),