firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Put waitFor back in keyboard_textfield_test integration test (#102315)

Browse Source
This commit is contained in:
LongCatIsLooong 2022-04-21 13:14:10 -07:00 committed by GitHub
parent b63689de69
commit 06314a073d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev/integration_tests/ui/lib/keyboard_textfield.dart
View File

@ -62,11 +62,10 @@ class _MyHomePageState extends State<MyHomePage> {
Text('$offset', Text('$offset',
key: const ValueKey<String>(keys.kOffsetText), key: const ValueKey<String>(keys.kOffsetText),
), ),
Text( if (isSoftKeyboardVisible) const Text(
isSoftKeyboardVisible ? 'keyboard visible' : 'keyboard hidden', 'keyboard visible',
key: const ValueKey<String>(keys.kKeyboardVisibleView), key: ValueKey<String>(keys.kKeyboardVisibleView),
), ),
const ElevatedButton(onPressed: debugDumpApp, child: Text('dump app')),
Expanded( Expanded(
child: ListView( child: ListView(
key: const ValueKey<String>(keys.kListView), key: const ValueKey<String>(keys.kListView),

21
dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
View File

@ -40,23 +40,10 @@ void main() {
// Bring up keyboard // Bring up keyboard
await driver.tap(textFieldFinder); await driver.tap(textFieldFinder);
const int keyboardTimeout = 3; // The blinking cursor may have animation. Do not wait for it to finish.
bool keyboardVisible = false; await driver.runUnsynchronized(() async {
for (int i = 0; i < keyboardTimeout; i++) { await driver.waitFor(keyboardVisibilityIndicatorFinder);
await Future<void>.delayed(const Duration(seconds: 1)); });
final String keyboardVisibilityText = await driver.getText(keyboardVisibilityIndicatorFinder);
keyboardVisible = keyboardVisibilityText == 'keyboard visible';
if (keyboardVisible) {
break;
}
}
if (!keyboardVisible) {
await driver.tap(find.text('dump app'));
}
// TODO(jmagman): Remove timeout once flake has been diagnosed. https://github.com/flutter/flutter/issues/96787
expect(keyboardVisible, isTrue);
// Ensure that TextField is visible again // Ensure that TextField is visible again
await driver.waitFor(textFieldFinder); await driver.waitFor(textFieldFinder);