added Semantics label to TextField with InputDecoration to let user k… (#151996)

Semantics label to TextField with InputDecoration to let user know about
existing suffix

Before: https://screenshot.googleplex.com/3U9QyZ6Pqx2xeCf
After: https://screenshot.googleplex.com/73BSKQJhssGCoZu

fixes b/341998411
fixes b/342002217

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This commit is contained in:
DBowen33 2024-07-24 16:18:44 -05:00 committed by GitHub
parent 6fdcb0a511
commit 06e915f869
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 30 additions and 16 deletions

View File

@ -30,25 +30,31 @@ class _MainWidget extends StatelessWidget {
),
body: ListView(
children: <Widget>[
const TextField(
key: Key('enabled text field'),
maxLines: null,
decoration: InputDecoration(
labelText: 'Email',
suffixText: '@gmail.com',
hintText: 'Enter your email',
Semantics(
label: 'Input field with suffix @gmail.com',
child: const TextField(
key: Key('enabled text field'),
maxLines: null,
decoration: InputDecoration(
labelText: 'Email',
suffixText: '@gmail.com',
hintText: 'Enter your email',
),
),
),
TextField(
key: const Key('disabled text field'),
maxLines: null,
decoration: const InputDecoration(
labelText: 'Email',
suffixText: '@gmail.com',
hintText: 'Enter your email',
Semantics(
label: 'Input field with suffix @gmail.com',
child: TextField(
key: const Key('disabled text field'),
maxLines: null,
decoration: const InputDecoration(
labelText: 'Email',
suffixText: '@gmail.com',
hintText: 'Enter your email',
),
enabled: false,
controller: TextEditingController(text: 'xyz'),
),
enabled: false,
controller: TextEditingController(text: 'xyz'),
),
],
),

View File

@ -54,4 +54,12 @@ void main() {
expect(size.height, 280);
}
});
testWidgets('text field wrapper exists', (WidgetTester tester) async {
await pumpsUseCase(tester, TextFieldUseCase());
const String textFieldLabel = 'Input field with suffix @gmail.com';
final Finder semanticsWidgets = find.bySemanticsLabel(RegExp(textFieldLabel));
expect(semanticsWidgets, findsExactly(2));
});
}