firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix variable check in xcode_backend.sh (#24368)

Browse Source 
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
This commit is contained in:
Dan Field 2018-11-14 18:54:51 -08:00 committed by GitHub
parent 64a8d44764
commit 091b73ab6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/devicelab/bin/tasks/module_test_ios.dart
View File

@ -154,8 +154,8 @@ Future<void> main() async {
'Debug', 'Debug',
'CODE_SIGNING_ALLOWED=NO', 'CODE_SIGNING_ALLOWED=NO',
'CODE_SIGNING_REQUIRED=NO', 'CODE_SIGNING_REQUIRED=NO',
'CODE_SIGNING_IDENTITY=""', 'CODE_SIGN_IDENTITY=',
'EXPANDED_CODE_SIGN_IDENTITY=""', 'EXPANDED_CODE_SIGN_IDENTITY=',
'CONFIGURATION_BUILD_DIR=${tempDir.path}', 'CONFIGURATION_BUILD_DIR=${tempDir.path}',
], ],
); );

2
packages/flutter_tools/bin/xcode_backend.sh
View File

@ -367,7 +367,7 @@ EmbedFlutterFrameworks() {
# Sign the binaries we moved. # Sign the binaries we moved.
local identity="${EXPANDED_CODE_SIGN_IDENTITY_NAME:-$CODE_SIGN_IDENTITY}" local identity="${EXPANDED_CODE_SIGN_IDENTITY_NAME:-$CODE_SIGN_IDENTITY}"
if (${identity} != ""); then if [[ -n "$identity" && "$identity" != "\"\"" ]]; then
RunCommand codesign --force --verbose --sign "${identity}" -- "${xcode_frameworks_dir}/App.framework/App" RunCommand codesign --force --verbose --sign "${identity}" -- "${xcode_frameworks_dir}/App.framework/App"
RunCommand codesign --force --verbose --sign "${identity}" -- "${xcode_frameworks_dir}/Flutter.framework/Flutter" RunCommand codesign --force --verbose --sign "${identity}" -- "${xcode_frameworks_dir}/Flutter.framework/Flutter"
fi fi