firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] remove Adreno denylist entries. (#161740)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/161209

testing on a 540 and everything seems to work now that we have the
Adreno specific workarounds added to the renderer. Its possible there
are some bugs that only exist on the early 600s but I guess we'll find
out.
This commit is contained in:
Jonah Williams 2025-01-16 18:44:31 -08:00 committed by GitHub
parent f2ce662fd2
commit 095f46c4a7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc
View File

@ -329,15 +329,6 @@ bool DriverInfoVK::IsEmulator() const {
}
bool DriverInfoVK::IsKnownBadDriver() const {
if (adreno_gpu_.has_value()) {
AdrenoGPU adreno = adreno_gpu_.value();
// 630 is the lowest version I've tested on the still works.
// I suspect earlier 600s should work but this is waiting on
// more devices for testing.
if (adreno < AdrenoGPU::kAdreno630) {
return true;
}
}
// Disable Maleoon series GPUs, see:
// https://github.com/flutter/flutter/issues/156623
if (vendor_ == VendorVK::kHuawei) {

19
engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc
View File

@ -163,16 +163,15 @@ TEST(DriverInfoVKTest, DriverParsingAdreno) {
}
TEST(DriverInfoVKTest, DisabledDevices) {
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 512"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 509"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 508"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 506"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 620"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 610"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 530"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 512"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 509"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 508"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 506"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 505"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 504"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 630"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650"));