From 0acfb216ac37b73f8c17348be21a19dafaac0ad4 Mon Sep 17 00:00:00 2001 From: Markus Aksli <68219924+markusaksli-nc@users.noreply.github.com> Date: Wed, 16 Feb 2022 21:42:36 +0200 Subject: [PATCH] Revert "Dismiss text selection toolbar with ESC (#98511)" (#98600) This reverts commit 9407700aa4a843885d7acca324773f85e3766743. --- .../lib/src/widgets/editable_text.dart | 1 - .../test/widgets/editable_text_test.dart | 35 ------------------- 2 files changed, 36 deletions(-) diff --git a/packages/flutter/lib/src/widgets/editable_text.dart b/packages/flutter/lib/src/widgets/editable_text.dart index 6f6ea858f6..d4d1f645e8 100644 --- a/packages/flutter/lib/src/widgets/editable_text.dart +++ b/packages/flutter/lib/src/widgets/editable_text.dart @@ -3150,7 +3150,6 @@ class EditableTextState extends State with AutomaticKeepAliveClien ReplaceTextIntent: _replaceTextAction, UpdateSelectionIntent: _updateSelectionAction, DirectionalFocusIntent: DirectionalFocusAction.forTextField(), - DismissIntent: CallbackAction(onInvoke: (_) => hideToolbar(false)), // Delete DeleteCharacterIntent: _makeOverridable(_DeleteTextAction(this, _characterBoundary)), diff --git a/packages/flutter/test/widgets/editable_text_test.dart b/packages/flutter/test/widgets/editable_text_test.dart index 7f5462db03..8ba96c63fe 100644 --- a/packages/flutter/test/widgets/editable_text_test.dart +++ b/packages/flutter/test/widgets/editable_text_test.dart @@ -1316,41 +1316,6 @@ void main() { expect(find.text('Paste'), kIsWeb ? findsNothing : findsOneWidget); }); - testWidgets('can hide toolbar with DismissIntent', (WidgetTester tester) async { - await tester.pumpWidget( - MaterialApp( - home: EditableText( - backgroundCursorColor: Colors.grey, - controller: controller, - focusNode: focusNode, - style: textStyle, - cursorColor: cursorColor, - selectionControls: materialTextSelectionControls, - ), - ), - ); - - final EditableTextState state = - tester.state(find.byType(EditableText)); - - // Show the toolbar - state.renderEditable.selectWordsInRange( - from: Offset.zero, - cause: SelectionChangedCause.tap, - ); - await tester.pump(); - - // On web, we don't let Flutter show the toolbar. - expect(state.showToolbar(), kIsWeb ? isFalse : isTrue); - await tester.pumpAndSettle(); - expect(find.text('Paste'), kIsWeb ? findsNothing : findsOneWidget); - - // Hide the menu using the DismissIntent. - await tester.sendKeyEvent(LogicalKeyboardKey.escape); - await tester.pump(); - expect(find.text('Paste'), findsNothing); - }); - testWidgets('Paste is shown only when there is something to paste', (WidgetTester tester) async { await tester.pumpWidget( MaterialApp(