From 0b73de95dae8036397ea5c717a9bf0a556fd3578 Mon Sep 17 00:00:00 2001
From: Elliott Sprehn <esprehn@chromium.org>
Date: Thu, 22 Jan 2015 17:04:10 -0800
Subject: [PATCH] Don't set expression attributes before they're bound.

We were cloning elements with all the attributes that contained
expressions like attrName="{{ foo }}" which meant we'd go through the
reflection process converting that value and also call the
attrNameChanged() callback and the attributeChanged() with the braced
string which the element didn't really want to know about.

After this patch we create a "clone source node" which is a copy of the
original element without the attributes that have the expressions and
use that when cloning, then we assign the properties using data binding
later.

R=abarth@chromium.org, ojan@chromium.org

Review URL: https://codereview.chromium.org/868973002
---
 examples/widgets/index.sky | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/widgets/index.sky b/examples/widgets/index.sky
index 98b0ab47a4..cb60858658 100644
--- a/examples/widgets/index.sky
+++ b/examples/widgets/index.sky
@@ -37,10 +37,10 @@
   </sky-box>
 
   <sky-box title='Checkboxes'>
-    <div><sky-checkbox id='checkbox' />Checkbox</div>
+    <div><sky-checkbox id='checkbox' checked='{{ checked }}'/>Checkbox</div>
     <div class="output">highlight: {{ myCheckbox.highlight }}</div>
     <div class="output">checked: {{ myCheckbox.checked }}</div>
-    <div><sky-checkbox id='checkbox' checked='{{ checked }}'/>Checkbox, default checked.</div>
+    <div><sky-checkbox id='checkbox' checked="true"/>Checkbox, default checked.</div>
     <div class="output">checked: {{ checked }}</div>
   </sky-box>