firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove line breaks from PR template (#28235)

Browse Source
This commit is contained in:
Michael Goderbauer 2019-02-20 18:40:33 -08:00 committed by GitHub
parent 2c558fdb21
commit 0bc94f2644
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -1,40 +1,27 @@
## Description ## Description
*Replace this paragraph with a description of what this PR is doing. If you're *Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).*
modifying existing behavior, describe the existing behavior, how this PR is
changing it, and what motivated the change. If you're changing visual
properties, consider including before/after screenshots (and runnable code
snippets to reproduce them).*
## Related Issues ## Related Issues
*Replace this paragraph with a list of issues related to this PR from our *Replace this paragraph with a list of issues related to this PR from our [issue database]. Indicate, which of these issues are resolved or fixed by this PR.*
[issue database]. Indicate, which of these issues are resolved or fixed by this
PR.*
## Checklist ## Checklist
Before you create this PR confirm that it meets all requirements listed below Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick
review process.
- [ ] I read the [Contributor Guide] and followed the process outlined there for - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
submitting PRs. - [ ] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
- [ ] My PR includes tests for *all* changed/updated/fixed behaviors (See
[Test Coverage]).
- [ ] All existing and new tests are passing. - [ ] All existing and new tests are passing.
- [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] The analyzer (`flutter analyze --flutter-repo`) does not report any - [ ] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
problems on my PR. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
- [ ] I read and followed the [Flutter Style Guide], including
[Features we expect every widget to implement].
- [ ] I signed the [CLA]. - [ ] I signed the [CLA].
- [ ] I am willing to follow-up on review comments in a timely manner. - [ ] I am willing to follow-up on review comments in a timely manner.
## Breaking Change ## Breaking Change
Does your PR require Flutter developers to manually update their apps Does your PR require Flutter developers to manually update their apps to accommodate your change?
to accommodate your change?
- [ ] Yes, this is a breaking change (Please read [Handling breaking changes]). - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
- [ ] No, this is *not* a breaking change. - [ ] No, this is *not* a breaking change.