firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] re-enable Adreno 630 (#161287)

Browse Source 
Part of https://github.com/flutter/flutter/issues/161209
This commit is contained in:
Jonah Williams 2025-01-08 13:19:03 -08:00 committed by GitHub
parent d8c4fc0bc6
commit 0c25fa4546
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc
View File

@ -331,16 +331,10 @@ bool DriverInfoVK::IsEmulator() const {
bool DriverInfoVK::IsKnownBadDriver() const { bool DriverInfoVK::IsKnownBadDriver() const {
if (adreno_gpu_.has_value()) { if (adreno_gpu_.has_value()) {
AdrenoGPU adreno = adreno_gpu_.value(); AdrenoGPU adreno = adreno_gpu_.value();
// See: // 630 is the lowest version I've tested on the still works.
// https://github.com/flutter/flutter/issues/154103 // I suspect earlier 600s should work but this is waiting on
// // more devices for testing.
// Reports "VK_INCOMPLETE" when compiling certain entity shader with if (adreno < AdrenoGPU::kAdreno630) {
// vkCreateGraphicsPipelines, which is not a valid return status.
// See https://github.com/flutter/flutter/issues/155185 .
//
// https://github.com/flutter/flutter/issues/155185
// Unknown crashes but device is not easily acquirable.
if (adreno <= AdrenoGPU::kAdreno630) {
return true; return true;
} }
} }

2
engine/src/flutter/impeller/renderer/backend/vulkan/driver_info_vk_unittests.cc
View File

@ -163,7 +163,6 @@ TEST(DriverInfoVKTest, DriverParsingAdreno) {
} }
TEST(DriverInfoVKTest, DisabledDevices) { TEST(DriverInfoVKTest, DisabledDevices) {
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 630"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620")); EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 620"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610")); EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 610"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530")); EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 530"));
@ -174,6 +173,7 @@ TEST(DriverInfoVKTest, DisabledDevices) {
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505")); EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 505"));
EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504")); EXPECT_TRUE(IsBadVersionTest("Adreno (TM) 504"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 630"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640")); EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 640"));
EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650")); EXPECT_FALSE(IsBadVersionTest("Adreno (TM) 650"));
} }