firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] add support for --enable-impeller to test device. (#140899)

Browse Source 
This allows unit tests to use the impeller backend, which can be useful for Scubas/golden tests.
This commit is contained in:
Jonah Williams 2024-01-03 11:14:49 -08:00 committed by GitHub
parent 0e11246b62
commit 0d378ed5ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter_tools/lib/src/commands/test.dart
View File

@ -74,6 +74,7 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
usesWebRendererOption();
usesDeviceUserOption();
usesFlavorOption();
addEnableImpellerFlag(verboseHelp: verboseHelp);
argParser
..addMultiOption('name',
@ -436,6 +437,7 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
enableDds: enableDds,
nullAssertions: boolArg(FlutterOptions.kNullAssertions),
usingCISystem: usingCISystem,
enableImpeller: ImpellerStatus.fromBool(argResults!['enable-impeller'] as bool?),
);
Device? integrationTestDevice;

5
packages/flutter_tools/lib/src/test/flutter_tester_device.dart
View File

@ -109,8 +109,13 @@ class FlutterTesterTestDevice extends TestDevice {
if (icudtlPath != null) '--icu-data-file-path=$icudtlPath',
'--enable-checked-mode',
'--verify-entry-points',
if (debuggingOptions.enableImpeller == ImpellerStatus.enabled)
'--enable-impeller'
else
...<String>[
'--enable-software-rendering',
'--skia-deterministic-rendering',
],
if (debuggingOptions.enableDartProfiling)
'--enable-dart-profiling',
'--non-interactive',

17
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View File

@ -996,6 +996,23 @@ dev_dependencies:
FileSystem: () => fs,
ProcessManager: () => FakeProcessManager.any(),
});
testUsingContext('Enables Impeller', () async {
final FakeFlutterTestRunner testRunner = FakeFlutterTestRunner(0);
final TestCommand testCommand = TestCommand(testRunner: testRunner);
final CommandRunner<void> commandRunner = createTestCommandRunner(testCommand);
await commandRunner.run(const <String>[
'test',
'--no-pub',
'--enable-impeller',
]);
expect(testRunner.lastDebuggingOptionsValue.enableImpeller, ImpellerStatus.enabled);
}, overrides: <Type, Generator>{
FileSystem: () => fs,
ProcessManager: () => FakeProcessManager.any(),
});
});
}