firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make it possible to download trace files on rooted devices using sky_tool stop_trace

Browse Source
This commit is contained in:
Ian Fischer 2015-08-31 17:12:09 -07:00
parent 99356d10c6
commit 0d7e90d590
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter/lib/sky_tool
View File

@ -952,6 +952,16 @@ class StopTracing(object):
logging.info('Downloading trace %s ...' % os.path.basename(device_path))
if device_path:
cmd = [ADB_PATH, 'root']
logging.info(' '.join(cmd))
output = subprocess.check_output(cmd)
match = re.match(r'.*cannot run as root.*', output
if match is not None:
logging.error('Unable to download trace file %s\n'
'You need to be able to run adb as root '
'on your android device' % device_path)
return 2
cmd = [ADB_PATH, 'pull', device_path]
logging.info(' '.join(cmd))
subprocess.check_output(cmd)