firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

update console output to specify post release steps (#102173)

Browse Source 
* update console output to specify post release steps

* move post release instructions

* update instructions for beta vs stable

* add logic to differentiate beta and stable steps
This commit is contained in:
Kevin Chisholm 2022-04-20 09:56:09 -05:00 committed by GitHub
parent 760c375b3a
commit 0f0da62fed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 49 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev/conductor/core/lib/src/next.dart
View File

@ -340,7 +340,8 @@ class NextContext extends Context {
'\t$kLuciPackagingConsoleLink', '\t$kLuciPackagingConsoleLink',
); );
if (autoAccept == false) { if (autoAccept == false) {
final bool response = await prompt('Have all packaging builds finished successfully?'); final bool response = await prompt(
'Have all packaging builds finished successfully and post release announcements been completed?');
if (!response) { if (!response) {
stdio.printError('Aborting command.'); stdio.printError('Aborting command.');
updateState(state, stdio.logs); updateState(state, stdio.logs);

64
dev/conductor/core/lib/src/state.dart
View File

@ -22,7 +22,8 @@ String luciConsoleLink(String channel, String groupName) {
<String>['flutter', 'engine', 'packaging'].contains(groupName), <String>['flutter', 'engine', 'packaging'].contains(groupName),
'group named $groupName not recognized', 'group named $groupName not recognized',
); );
final String consoleName = channel == 'master' ? groupName : '${channel}_$groupName'; final String consoleName =
channel == 'master' ? groupName : '${channel}_$groupName';
return 'https://ci.chromium.org/p/flutter/g/$consoleName/console'; return 'https://ci.chromium.org/p/flutter/g/$consoleName/console';
} }
@ -43,15 +44,18 @@ String presentState(pb.ConductorState state) {
buffer.writeln('Release channel: ${state.releaseChannel}'); buffer.writeln('Release channel: ${state.releaseChannel}');
buffer.writeln('Release version: ${state.releaseVersion}'); buffer.writeln('Release version: ${state.releaseVersion}');
buffer.writeln(); buffer.writeln();
buffer.writeln('Release started at: ${DateTime.fromMillisecondsSinceEpoch(state.createdDate.toInt())}'); buffer.writeln(
buffer.writeln('Last updated at: ${DateTime.fromMillisecondsSinceEpoch(state.lastUpdatedDate.toInt())}'); 'Release started at: ${DateTime.fromMillisecondsSinceEpoch(state.createdDate.toInt())}');
buffer.writeln(
'Last updated at: ${DateTime.fromMillisecondsSinceEpoch(state.lastUpdatedDate.toInt())}');
buffer.writeln(); buffer.writeln();
buffer.writeln('Engine Repo'); buffer.writeln('Engine Repo');
buffer.writeln('\tCandidate branch: ${state.engine.candidateBranch}'); buffer.writeln('\tCandidate branch: ${state.engine.candidateBranch}');
buffer.writeln('\tStarting git HEAD: ${state.engine.startingGitHead}'); buffer.writeln('\tStarting git HEAD: ${state.engine.startingGitHead}');
buffer.writeln('\tCurrent git HEAD: ${state.engine.currentGitHead}'); buffer.writeln('\tCurrent git HEAD: ${state.engine.currentGitHead}');
buffer.writeln('\tPath to checkout: ${state.engine.checkoutPath}'); buffer.writeln('\tPath to checkout: ${state.engine.checkoutPath}');
buffer.writeln('\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'engine')}'); buffer.writeln(
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'engine')}');
if (state.engine.cherrypicks.isNotEmpty) { if (state.engine.cherrypicks.isNotEmpty) {
buffer.writeln('${state.engine.cherrypicks.length} Engine Cherrypicks:'); buffer.writeln('${state.engine.cherrypicks.length} Engine Cherrypicks:');
for (final pb.Cherrypick cherrypick in state.engine.cherrypicks) { for (final pb.Cherrypick cherrypick in state.engine.cherrypicks) {
@ -60,7 +64,8 @@ String presentState(pb.ConductorState state) {
} else { } else {
buffer.writeln('0 Engine cherrypicks.'); buffer.writeln('0 Engine cherrypicks.');
} }
if (state.engine.dartRevision != null && state.engine.dartRevision.isNotEmpty) { if (state.engine.dartRevision != null &&
state.engine.dartRevision.isNotEmpty) {
buffer.writeln('New Dart SDK revision: ${state.engine.dartRevision}'); buffer.writeln('New Dart SDK revision: ${state.engine.dartRevision}');
} }
buffer.writeln('Framework Repo'); buffer.writeln('Framework Repo');
@ -68,9 +73,11 @@ String presentState(pb.ConductorState state) {
buffer.writeln('\tStarting git HEAD: ${state.framework.startingGitHead}'); buffer.writeln('\tStarting git HEAD: ${state.framework.startingGitHead}');
buffer.writeln('\tCurrent git HEAD: ${state.framework.currentGitHead}'); buffer.writeln('\tCurrent git HEAD: ${state.framework.currentGitHead}');
buffer.writeln('\tPath to checkout: ${state.framework.checkoutPath}'); buffer.writeln('\tPath to checkout: ${state.framework.checkoutPath}');
buffer.writeln('\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'flutter')}'); buffer.writeln(
'\tPost-submit LUCI dashboard: ${luciConsoleLink(state.releaseChannel, 'flutter')}');
if (state.framework.cherrypicks.isNotEmpty) { if (state.framework.cherrypicks.isNotEmpty) {
buffer.writeln('${state.framework.cherrypicks.length} Framework Cherrypicks:'); buffer.writeln(
'${state.framework.cherrypicks.length} Framework Cherrypicks:');
for (final pb.Cherrypick cherrypick in state.framework.cherrypicks) { for (final pb.Cherrypick cherrypick in state.framework.cherrypicks) {
buffer.writeln('\t${cherrypick.trunkRevision} - ${cherrypick.state}'); buffer.writeln('\t${cherrypick.trunkRevision} - ${cherrypick.state}');
} }
@ -125,7 +132,8 @@ String phaseInstructions(pb.ConductorState state) {
return <String>[ return <String>[
'You must now manually apply the following engine cherrypicks to the checkout', 'You must now manually apply the following engine cherrypicks to the checkout',
'at ${state.engine.checkoutPath} in order:', 'at ${state.engine.checkoutPath} in order:',
for (final pb.Cherrypick cherrypick in state.engine.cherrypicks) '\t${cherrypick.trunkRevision}', for (final pb.Cherrypick cherrypick in state.engine.cherrypicks)
'\t${cherrypick.trunkRevision}',
'See $kReleaseDocumentationUrl for more information.', 'See $kReleaseDocumentationUrl for more information.',
].join('\n'); ].join('\n');
case ReleasePhase.CODESIGN_ENGINE_BINARIES: case ReleasePhase.CODESIGN_ENGINE_BINARIES:
@ -147,19 +155,24 @@ String phaseInstructions(pb.ConductorState state) {
'validate post-submit CI, and then codesign the binaries on the merge commit.', 'validate post-submit CI, and then codesign the binaries on the merge commit.',
].join('\n'); ].join('\n');
case ReleasePhase.APPLY_FRAMEWORK_CHERRYPICKS: case ReleasePhase.APPLY_FRAMEWORK_CHERRYPICKS:
final List<pb.Cherrypick> outstandingCherrypicks = state.framework.cherrypicks.where( final List<pb.Cherrypick> outstandingCherrypicks =
state.framework.cherrypicks.where(
(pb.Cherrypick cp) { (pb.Cherrypick cp) {
return cp.state == pb.CherrypickState.PENDING || cp.state == pb.CherrypickState.PENDING_WITH_CONFLICT; return cp.state == pb.CherrypickState.PENDING ||
cp.state == pb.CherrypickState.PENDING_WITH_CONFLICT;
}, },
).toList(); ).toList();
if (outstandingCherrypicks.isNotEmpty) { if (outstandingCherrypicks.isNotEmpty) {
return <String>[ return <String>[
'You must now manually apply the following framework cherrypicks to the checkout', 'You must now manually apply the following framework cherrypicks to the checkout',
'at ${state.framework.checkoutPath} in order:', 'at ${state.framework.checkoutPath} in order:',
for (final pb.Cherrypick cherrypick in outstandingCherrypicks) '\t${cherrypick.trunkRevision}', for (final pb.Cherrypick cherrypick in outstandingCherrypicks)
'\t${cherrypick.trunkRevision}',
].join('\n'); ].join('\n');
} }
return <String>['Either all cherrypicks have been auto-applied or there were none.'].join('\n'); return <String>[
'Either all cherrypicks have been auto-applied or there were none.'
].join('\n');
case ReleasePhase.PUBLISH_VERSION: case ReleasePhase.PUBLISH_VERSION:
if (!requiresFrameworkPR(state)) { if (!requiresFrameworkPR(state)) {
return 'Since there are no code changes in this release, no Framework ' return 'Since there are no code changes in this release, no Framework '
@ -182,7 +195,24 @@ String phaseInstructions(pb.ConductorState state) {
case ReleasePhase.VERIFY_RELEASE: case ReleasePhase.VERIFY_RELEASE:
return 'Release archive packages must be verified on cloud storage: ${luciConsoleLink(state.releaseChannel, 'packaging')}'; return 'Release archive packages must be verified on cloud storage: ${luciConsoleLink(state.releaseChannel, 'packaging')}';
case ReleasePhase.RELEASE_COMPLETED: case ReleasePhase.RELEASE_COMPLETED:
return 'This release has been completed.'; if (state.releaseChannel == 'beta') {
return <String>[
'Ensure the following post release steps are complete:',
'\t 1. Post announcement to discord',
'\t 2. Post announcement flutter release hotline chat room',
'-----------------------------------------------------------------------',
'This release has been completed.'
].join('\n');
}
return <String>[
'Ensure the following post release steps are complete:',
'\t 1. Update hotfix to stable wiki following documentation best practices',
'\t 2. Post announcement to flutter-announce group',
'\t 3. Post announcement to discord',
'\t 4. Post announcement flutter release hotline chat room',
'-----------------------------------------------------------------------',
'This release has been completed.'
].join('\n');
} }
// For analyzer // For analyzer
throw ConductorException('Unimplemented phase ${state.currentPhase}'); throw ConductorException('Unimplemented phase ${state.currentPhase}');
@ -193,8 +223,8 @@ String phaseInstructions(pb.ConductorState state) {
/// First group = git host (currently must be github.com) /// First group = git host (currently must be github.com)
/// Second group = account name /// Second group = account name
/// Third group = repo name /// Third group = repo name
final RegExp githubRemotePattern = final RegExp githubRemotePattern = RegExp(
RegExp(r'^(git@github\.com:|https?:\/\/github\.com\/)([a-zA-Z0-9_-]+)\/([a-zA-Z0-9_-]+)(\.git)?$'); r'^(git@github\.com:|https?:\/\/github\.com\/)([a-zA-Z0-9_-]+)\/([a-zA-Z0-9_-]+)(\.git)?$');
/// Parses a Git remote URL and returns the account name. /// Parses a Git remote URL and returns the account name.
/// ///
@ -271,8 +301,8 @@ bool requiresFrameworkPR(pb.ConductorState state) {
if (requiresEnginePR(state)) { if (requiresEnginePR(state)) {
return true; return true;
} }
final bool hasRequiredCherrypicks = final bool hasRequiredCherrypicks = state.framework.cherrypicks
state.framework.cherrypicks.any((pb.Cherrypick cp) => cp.state != pb.CherrypickState.ABANDONED); .any((pb.Cherrypick cp) => cp.state != pb.CherrypickState.ABANDONED);
if (hasRequiredCherrypicks) { if (hasRequiredCherrypicks) {
return true; return true;
} }