From 0f91f0d48a93729eb61a9a4df8110dc0018a04ce Mon Sep 17 00:00:00 2001 From: Michael Goderbauer Date: Tue, 2 Mar 2021 21:14:03 -0800 Subject: [PATCH] Clean-up analysis_options files (#77098) --- analysis_options.yaml | 7 ++----- dev/missing_dependency_tests/analysis_options.yaml | 1 - examples/layers/analysis_options.yaml | 11 ----------- packages/flutter/analysis_options.yaml | 7 ++----- packages/flutter/test_private/analysis_options.yaml | 1 - packages/flutter_driver/analysis_options.yaml | 11 ----------- packages/flutter_goldens/analysis_options.yaml | 4 ---- packages/flutter_goldens_client/analysis_options.yaml | 4 ---- packages/flutter_goldens_client/lib/skia_client.dart | 4 ++++ packages/flutter_localizations/analysis_options.yaml | 11 ----------- packages/flutter_test/analysis_options.yaml | 10 ---------- 11 files changed, 8 insertions(+), 63 deletions(-) delete mode 100644 examples/layers/analysis_options.yaml delete mode 100644 packages/flutter/test_private/analysis_options.yaml delete mode 100644 packages/flutter_driver/analysis_options.yaml delete mode 100644 packages/flutter_goldens/analysis_options.yaml delete mode 100644 packages/flutter_goldens_client/analysis_options.yaml delete mode 100644 packages/flutter_localizations/analysis_options.yaml delete mode 100644 packages/flutter_test/analysis_options.yaml diff --git a/analysis_options.yaml b/analysis_options.yaml index 8c7481e1df..3ad417e584 100644 --- a/analysis_options.yaml +++ b/analysis_options.yaml @@ -36,13 +36,10 @@ analyzer: # Stream and not importing dart:async # Please see https://github.com/flutter/flutter/pull/24528 for details. sdk_version_async_exported_from_core: ignore + # Turned off until null-safe rollout is complete. + unnecessary_null_comparison: ignore exclude: - "bin/cache/**" - # the following two are relative to the stocks example and the flutter package respectively - # see https://github.com/dart-lang/sdk/issues/28463 - - "lib/i18n/messages_*.dart" - - "lib/src/http/**" - - "test_fixes/**" linter: rules: diff --git a/dev/missing_dependency_tests/analysis_options.yaml b/dev/missing_dependency_tests/analysis_options.yaml index ae6f18d359..4c1615ac5a 100644 --- a/dev/missing_dependency_tests/analysis_options.yaml +++ b/dev/missing_dependency_tests/analysis_options.yaml @@ -1,4 +1,3 @@ analyzer: exclude: - '**' - diff --git a/examples/layers/analysis_options.yaml b/examples/layers/analysis_options.yaml deleted file mode 100644 index 0620babbbb..0000000000 --- a/examples/layers/analysis_options.yaml +++ /dev/null @@ -1,11 +0,0 @@ -# Use the parent analysis options settings and enable null-experiment. - -include: ../../analysis_options.yaml - -analyzer: - errors: - always_require_non_null_named_parameters: false # not needed with nnbd - type_init_formals: false # https://github.com/dart-lang/linter/issues/2192 - unrelated_type_equality_checks: false # https://github.com/dart-lang/linter/issues/2196 - void_checks: false # https://github.com/dart-lang/linter/issues/2185 - unnecessary_null_comparison: false # Turned off until null-safe rollout is complete. diff --git a/packages/flutter/analysis_options.yaml b/packages/flutter/analysis_options.yaml index ad8b22ef40..e61f982d45 100644 --- a/packages/flutter/analysis_options.yaml +++ b/packages/flutter/analysis_options.yaml @@ -1,8 +1,5 @@ -# Use the parent analysis options settings and enable null-experiment. - include: ../analysis_options.yaml analyzer: - errors: - always_require_non_null_named_parameters: false # not needed with nnbd - unnecessary_null_comparison: false # Turned off until null-safe rollout is complete. + exclude: + - "test_fixes/**" diff --git a/packages/flutter/test_private/analysis_options.yaml b/packages/flutter/test_private/analysis_options.yaml deleted file mode 100644 index 5e2133eb69..0000000000 --- a/packages/flutter/test_private/analysis_options.yaml +++ /dev/null @@ -1 +0,0 @@ -include: ../analysis_options.yaml diff --git a/packages/flutter_driver/analysis_options.yaml b/packages/flutter_driver/analysis_options.yaml deleted file mode 100644 index eb8a8500b7..0000000000 --- a/packages/flutter_driver/analysis_options.yaml +++ /dev/null @@ -1,11 +0,0 @@ -# Use the parent analysis options settings and enable null-experiment. - -include: ../analysis_options.yaml - -analyzer: - errors: - always_require_non_null_named_parameters: false # not needed with nnbd - type_init_formals: false # https://github.com/dart-lang/linter/issues/2192 - unrelated_type_equality_checks: false # https://github.com/dart-lang/linter/issues/2196 - void_checks: false # https://github.com/dart-lang/linter/issues/2185 - unnecessary_null_comparison: false # Turned off until null-safe rollout is complete. diff --git a/packages/flutter_goldens/analysis_options.yaml b/packages/flutter_goldens/analysis_options.yaml deleted file mode 100644 index b8591ca6db..0000000000 --- a/packages/flutter_goldens/analysis_options.yaml +++ /dev/null @@ -1,4 +0,0 @@ -# Use the analysis options settings from the top level of the repo (not -# the ones from above, which include the `public_member_api_docs` rule). - -include: ../../analysis_options.yaml diff --git a/packages/flutter_goldens_client/analysis_options.yaml b/packages/flutter_goldens_client/analysis_options.yaml deleted file mode 100644 index b8591ca6db..0000000000 --- a/packages/flutter_goldens_client/analysis_options.yaml +++ /dev/null @@ -1,4 +0,0 @@ -# Use the analysis options settings from the top level of the repo (not -# the ones from above, which include the `public_member_api_docs` rule). - -include: ../../analysis_options.yaml diff --git a/packages/flutter_goldens_client/lib/skia_client.dart b/packages/flutter_goldens_client/lib/skia_client.dart index 36586821b0..0eb9f0b5b0 100644 --- a/packages/flutter_goldens_client/lib/skia_client.dart +++ b/packages/flutter_goldens_client/lib/skia_client.dart @@ -22,6 +22,10 @@ const String _kTestBrowserKey = 'FLUTTER_TEST_BROWSER'; /// A client for uploading image tests and making baseline requests to the /// Flutter Gold Dashboard. class SkiaGoldClient { + /// Creates a [SkiaGoldClient] with the given [workDirectory]. + /// + /// All other parameters are optional. They may be provided in tests to + /// override the defaults for [fs], [process], [platform], and [httpClient]. SkiaGoldClient( this.workDirectory, { this.fs = const LocalFileSystem(), diff --git a/packages/flutter_localizations/analysis_options.yaml b/packages/flutter_localizations/analysis_options.yaml deleted file mode 100644 index eb8a8500b7..0000000000 --- a/packages/flutter_localizations/analysis_options.yaml +++ /dev/null @@ -1,11 +0,0 @@ -# Use the parent analysis options settings and enable null-experiment. - -include: ../analysis_options.yaml - -analyzer: - errors: - always_require_non_null_named_parameters: false # not needed with nnbd - type_init_formals: false # https://github.com/dart-lang/linter/issues/2192 - unrelated_type_equality_checks: false # https://github.com/dart-lang/linter/issues/2196 - void_checks: false # https://github.com/dart-lang/linter/issues/2185 - unnecessary_null_comparison: false # Turned off until null-safe rollout is complete. diff --git a/packages/flutter_test/analysis_options.yaml b/packages/flutter_test/analysis_options.yaml deleted file mode 100644 index 0125e40fd3..0000000000 --- a/packages/flutter_test/analysis_options.yaml +++ /dev/null @@ -1,10 +0,0 @@ -# Use the parent analysis options settings and enable null-experiment. - -include: ../analysis_options.yaml - -analyzer: - errors: - always_require_non_null_named_parameters: false # not needed with nnbd - unrelated_type_equality_checks: false # https://github.com/dart-lang/linter/issues/2196 - void_checks: false # https://github.com/dart-lang/linter/issues/2185 - unnecessary_null_comparison: false # Turned off until null-safe rollout is complete.