firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Pin iOS module test plugin versions (#63445)

Browse Source
This commit is contained in:
Jenn Magder 2020-08-11 06:26:05 -07:00 committed by GitHub
parent b09dee59bf
commit 0fe1adadd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dev/bots/test.dart
View File

@ -1223,8 +1223,7 @@ Future<void> _runHostOnlyDeviceLabTests() async {
() => _runDevicelabTest('module_test', environment: gradleEnvironment, testEmbeddingV2: true), () => _runDevicelabTest('module_test', environment: gradleEnvironment, testEmbeddingV2: true),
() => _runDevicelabTest('plugin_dependencies_test', environment: gradleEnvironment), () => _runDevicelabTest('plugin_dependencies_test', environment: gradleEnvironment),
// TODO(magder): https://github.com/flutter/flutter/issues/63447 if (Platform.isMacOS) () => _runDevicelabTest('module_test_ios'),
// if (Platform.isMacOS) () => _runDevicelabTest('module_test_ios'),
if (Platform.isMacOS) () => _runDevicelabTest('build_ios_framework_module_test'), if (Platform.isMacOS) () => _runDevicelabTest('build_ios_framework_module_test'),
if (Platform.isMacOS) () => _runDevicelabTest('plugin_lint_mac'), if (Platform.isMacOS) () => _runDevicelabTest('plugin_lint_mac'),
() => _runDevicelabTest('plugin_test', environment: gradleEnvironment), () => _runDevicelabTest('plugin_test', environment: gradleEnvironment),

8
dev/devicelab/bin/tasks/module_test_ios.dart
View File

@ -148,7 +148,7 @@ Future<void> main() async {
content = content.replaceFirst( content = content.replaceFirst(
'\ndependencies:\n', '\ndependencies:\n',
// One dynamic framework, one static framework, and one that does not support iOS. // One dynamic framework, one static framework, and one that does not support iOS.
'\ndependencies:\n device_info:\n google_maps_flutter:\n android_alarm_manager:\n', '\ndependencies:\n device_info: 0.4.2+4\n google_sign_in: 4.5.1\n android_alarm_manager: 0.4.5+11\n',
); );
await pubspec.writeAsString(content, flush: true); await pubspec.writeAsString(content, flush: true);
await inDirectory(projectDir, () async { await inDirectory(projectDir, () async {
@ -163,7 +163,7 @@ Future<void> main() async {
await inDirectory(projectDir, () async { await inDirectory(projectDir, () async {
await flutter( await flutter(
'build', 'build',
options: <String>['ios', '--no-codesign'], options: <String>['ios', '--no-codesign', '-v'],
); );
}); });
@ -178,7 +178,7 @@ Future<void> main() async {
if (!podfileLockOutput.contains(':path: Flutter/engine') if (!podfileLockOutput.contains(':path: Flutter/engine')
|| !podfileLockOutput.contains(':path: Flutter/FlutterPluginRegistrant') || !podfileLockOutput.contains(':path: Flutter/FlutterPluginRegistrant')
|| !podfileLockOutput.contains(':path: Flutter/.symlinks/device_info/ios') || !podfileLockOutput.contains(':path: Flutter/.symlinks/device_info/ios')
|| !podfileLockOutput.contains(':path: Flutter/.symlinks/google_maps_flutter/ios') || !podfileLockOutput.contains(':path: Flutter/.symlinks/google_sign_in/ios')
|| podfileLockOutput.contains('android_alarm_manager')) { || podfileLockOutput.contains('android_alarm_manager')) {
return TaskResult.failure('Building ephemeral host app Podfile.lock does not contain expected pods'); return TaskResult.failure('Building ephemeral host app Podfile.lock does not contain expected pods');
} }
@ -186,7 +186,7 @@ Future<void> main() async {
checkFileExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'device_info.framework', 'device_info')); checkFileExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'device_info.framework', 'device_info'));
// Static, no embedded framework. // Static, no embedded framework.
checkDirectoryNotExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'google_maps_flutter.framework')); checkDirectoryNotExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'google_sign_in.framework'));
// Android-only, no embedded framework. // Android-only, no embedded framework.
checkDirectoryNotExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'android_alarm_manager.framework')); checkDirectoryNotExists(path.join(ephemeralIOSHostApp.path, 'Frameworks', 'android_alarm_manager.framework'));