firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Raise an exception when invalid subshard name (#113222)

Browse Source
This commit is contained in:
Jesús S Guerrero 2022-10-25 10:41:44 -07:00 committed by GitHub
parent 563e0a4aae
commit 0fe29f5857
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/bots/test.dart
View File

@ -1972,7 +1972,7 @@ List<T> _selectIndexOfTotalSubshard<T>(List<T> tests, {String subshardKey = kSub
foundError(<String>[ foundError(<String>[
'${red}Invalid subshard name "$subshardName". Expected format "[int]_[int]" ex. "1_3"', '${red}Invalid subshard name "$subshardName". Expected format "[int]_[int]" ex. "1_3"',
]); ]);
return <T>[]; throw Exception('Invalid subshard name: $subshardName');
} }
// One-indexed. // One-indexed.
final int index = int.parse(match.group(1)!); final int index = int.parse(match.group(1)!);

8
dev/bots/test/test_test.dart
View File

@ -144,5 +144,13 @@ void main() {
expectExitCode(result, 1); expectExitCode(result, 1);
expect(result.stdout, contains('Invalid subshard name')); expect(result.stdout, contains('Invalid subshard name'));
}); });
test('exits with code 255 when invalid SUBSHARD name', () async {
final ProcessResult result = await runScript(
<String, String>{'SHARD': kTestHarnessShardName, 'SUBSHARD': 'invalid_name'},
);
expectExitCode(result, 255);
expect(result.stdout, contains('Invalid subshard name'));
});
}); });
} }