firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix and remove a few no-shuffle tags in flutter_tools. (#157656)

Browse Source 
Two of the tests, `test_test` and `break_on_framework_exceptions`, no longer appear to leak (without changes). Perhaps underlying infrastructure has changed, or some other bug in the tool itself was fixed in meantime.

`packages_test` required resetting `Cache.flutterRoot`.

Work towards https://github.com/flutter/flutter/issues/85160.
This commit is contained in:
Matan Lurey 2024-10-29 12:01:54 -07:00 committed by GitHub
parent 42132e879b
commit 1068d31382
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/flutter_tools/test/commands.shard/permeable/packages_test.dart
View File

@ -2,13 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
// dependencies have been fixed.
// https://github.com/flutter/flutter/issues/85160
// Fails with "flutter test --test-randomize-ordering-seed=1000"
@Tags(<String>['no-shuffle'])
library;
import 'dart:async'; import 'dart:async';
import 'dart:convert'; import 'dart:convert';
@ -38,9 +31,15 @@ void main() {
setUp(() { setUp(() {
mockStdio = FakeStdio()..stdout.terminalColumns = 80; mockStdio = FakeStdio()..stdout.terminalColumns = 80;
// Some tests below override this with a blank root, always reset it.
Cache.flutterRoot = null;
});
setUpAll(() {
Cache.disableLocking();
}); });
Cache.disableLocking();
group('packages get/upgrade', () { group('packages get/upgrade', () {
late Directory tempDir; late Directory tempDir;
late FakeAnalytics fakeAnalytics; late FakeAnalytics fakeAnalytics;

7
packages/flutter_tools/test/integration.shard/break_on_framework_exceptions_test.dart
View File

@ -2,13 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
// dependencies have been fixed.
// https://github.com/flutter/flutter/issues/85160
// Fails with "flutter test --test-randomize-ordering-seed=1000"
@Tags(<String>['no-shuffle'])
library;
import 'dart:async'; import 'dart:async';
import 'package:file/file.dart'; import 'package:file/file.dart';

7
packages/flutter_tools/test/integration.shard/test_test.dart
View File

@ -2,13 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// TODO(gspencergoog): Remove this tag once this test's state leaks/test
// dependencies have been fixed.
// https://github.com/flutter/flutter/issues/85160
// Fails with "flutter test --test-randomize-ordering-seed=1000"
@Tags(<String>['no-shuffle'])
library;
import 'dart:async'; import 'dart:async';
import 'dart:convert'; import 'dart:convert';