firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use const instead of final with const declarations (#14253)

Browse Source
This commit is contained in:
Alexandre Ardhuin 2018-01-25 19:28:22 +01:00 committed by GitHub
parent 34ff00a752
commit 10f721c8a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
24 changed files with 137 additions and 137 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dev/tools/vitool/lib/vitool.dart
View File

@ -292,7 +292,7 @@ class SvgPath {
final List<SvgPathCommand> commands; final List<SvgPathCommand> commands;
final double opacity; final double opacity;
static final String _pathCommandAtom = ' *([a-zA-Z]) *([\-\.0-9 ,]*)'; static const String _pathCommandAtom = ' *([a-zA-Z]) *([\-\.0-9 ,]*)';
static final RegExp _pathCommandValidator = new RegExp('^($_pathCommandAtom)*\$'); static final RegExp _pathCommandValidator = new RegExp('^($_pathCommandAtom)*\$');
static final RegExp _pathCommandMatcher = new RegExp(_pathCommandAtom); static final RegExp _pathCommandMatcher = new RegExp(_pathCommandAtom);
@ -460,7 +460,7 @@ class _Transform {
} }
final String _transformCommandAtom = ' *([^(]+)\\(([^)]*)\\)'; const String _transformCommandAtom = ' *([^(]+)\\(([^)]*)\\)';
final RegExp _transformValidator = new RegExp('^($_transformCommandAtom)*\$'); final RegExp _transformValidator = new RegExp('^($_transformCommandAtom)*\$');
final RegExp _transformCommand = new RegExp(_transformCommandAtom); final RegExp _transformCommand = new RegExp(_transformCommandAtom);

2
examples/flutter_gallery/lib/demo/material/cards_demo.dart
View File

@ -51,7 +51,7 @@ class TravelDestinationItem extends StatelessWidget {
: assert(destination != null && destination.isValid), : assert(destination != null && destination.isValid),
super(key: key); super(key: key);
static final double height = 366.0; static const double height = 366.0;
final TravelDestination destination; final TravelDestination destination;
@override @override

2
examples/flutter_gallery/lib/demo/material/tabs_demo.dart
View File

@ -94,7 +94,7 @@ final Map<_Page, List<_CardData>> _allPages = <_Page, List<_CardData>>{
class _CardDataItem extends StatelessWidget { class _CardDataItem extends StatelessWidget {
const _CardDataItem({ this.page, this.data }); const _CardDataItem({ this.page, this.data });
static final double height = 272.0; static const double height = 272.0;
final _Page page; final _Page page;
final _CardData data; final _CardData data;

10
examples/flutter_gallery/lib/demo/shrine/shrine_home.dart
View File

@ -200,11 +200,11 @@ class _FeaturePriceItem extends _PriceItem {
class _HeadingLayout extends MultiChildLayoutDelegate { class _HeadingLayout extends MultiChildLayoutDelegate {
_HeadingLayout(); _HeadingLayout();
static final String price = 'price'; static const String price = 'price';
static final String image = 'image'; static const String image = 'image';
static final String title = 'title'; static const String title = 'title';
static final String description = 'description'; static const String description = 'description';
static final String vendor = 'vendor'; static const String vendor = 'vendor';
@override @override
void performLayout(Size size) { void performLayout(Size size) {

8
examples/flutter_gallery/lib/demo/shrine/shrine_order.dart
View File

@ -101,10 +101,10 @@ class _VendorItem extends StatelessWidget {
class _HeadingLayout extends MultiChildLayoutDelegate { class _HeadingLayout extends MultiChildLayoutDelegate {
_HeadingLayout(); _HeadingLayout();
static final String image = 'image'; static const String image = 'image';
static final String icon = 'icon'; static const String icon = 'icon';
static final String product = 'product'; static const String product = 'product';
static final String vendor = 'vendor'; static const String vendor = 'vendor';
@override @override
void performLayout(Size size) { void performLayout(Size size) {

2
examples/flutter_gallery/test_driver/transitions_perf_test.dart
View File

@ -82,7 +82,7 @@ const List<Demo> demos = const <Demo>[
const Demo('Typography'), const Demo('Typography'),
]; ];
final FileSystem _fs = const LocalFileSystem(); const FileSystem _fs = const LocalFileSystem();
const Duration kWaitBetweenActions = const Duration(milliseconds: 250); const Duration kWaitBetweenActions = const Duration(milliseconds: 250);

4
examples/layers/widgets/styled_text.dart
View File

@ -25,8 +25,8 @@ final List<List<String>> _kNameLines = _kDialogText
final TextStyle _kDaveStyle = new TextStyle(color: Colors.indigo.shade400, height: 1.8); final TextStyle _kDaveStyle = new TextStyle(color: Colors.indigo.shade400, height: 1.8);
final TextStyle _kHalStyle = new TextStyle(color: Colors.red.shade400, fontFamily: 'monospace'); final TextStyle _kHalStyle = new TextStyle(color: Colors.red.shade400, fontFamily: 'monospace');
final TextStyle _kBold = const TextStyle(fontWeight: FontWeight.bold); const TextStyle _kBold = const TextStyle(fontWeight: FontWeight.bold);
final TextStyle _kUnderline = const TextStyle( const TextStyle _kUnderline = const TextStyle(
decoration: TextDecoration.underline, decoration: TextDecoration.underline,
decorationColor: const Color(0xFF000000), decorationColor: const Color(0xFF000000),
decorationStyle: TextDecorationStyle.wavy decorationStyle: TextDecorationStyle.wavy

2
packages/flutter/lib/src/cupertino/slider.dart
View File

@ -182,7 +182,7 @@ const double _kPadding = 8.0;
const Color _kTrackColor = const Color(0xFFB5B5B5); const Color _kTrackColor = const Color(0xFFB5B5B5);
const double _kSliderHeight = 2.0 * (CupertinoThumbPainter.radius + _kPadding); const double _kSliderHeight = 2.0 * (CupertinoThumbPainter.radius + _kPadding);
const double _kSliderWidth = 176.0; // Matches Material Design slider. const double _kSliderWidth = 176.0; // Matches Material Design slider.
final Duration _kDiscreteTransitionDuration = const Duration(milliseconds: 500); const Duration _kDiscreteTransitionDuration = const Duration(milliseconds: 500);
const double _kAdjustmentUnit = 0.1; // Matches iOS implementation of material slider. const double _kAdjustmentUnit = 0.1; // Matches iOS implementation of material slider.

2
packages/flutter/lib/src/material/slider.dart
View File

@ -289,7 +289,7 @@ final Color _kActiveTrackColor = Colors.grey;
final Tween<double> _kReactionRadiusTween = new Tween<double>(begin: _kThumbRadius, end: _kReactionRadius); final Tween<double> _kReactionRadiusTween = new Tween<double>(begin: _kThumbRadius, end: _kReactionRadius);
final Tween<double> _kThumbRadiusTween = new Tween<double>(begin: _kThumbRadius, end: _kActiveThumbRadius); final Tween<double> _kThumbRadiusTween = new Tween<double>(begin: _kThumbRadius, end: _kActiveThumbRadius);
final ColorTween _kTickColorTween = new ColorTween(begin: Colors.transparent, end: Colors.black54); final ColorTween _kTickColorTween = new ColorTween(begin: Colors.transparent, end: Colors.black54);
final Duration _kDiscreteTransitionDuration = const Duration(milliseconds: 500); const Duration _kDiscreteTransitionDuration = const Duration(milliseconds: 500);
const double _kLabelBalloonRadius = 14.0; const double _kLabelBalloonRadius = 14.0;
final Tween<double> _kLabelBalloonCenterTween = new Tween<double>(begin: 0.0, end: -_kLabelBalloonRadius * 2.0); final Tween<double> _kLabelBalloonCenterTween = new Tween<double>(begin: 0.0, end: -_kLabelBalloonRadius * 2.0);

6
packages/flutter/lib/src/material/user_accounts_drawer_header.dart
View File

@ -165,9 +165,9 @@ class _AccountDetailsLayout extends MultiChildLayoutDelegate {
_AccountDetailsLayout({ @required this.textDirection }); _AccountDetailsLayout({ @required this.textDirection });
static final String accountName = 'accountName'; static const String accountName = 'accountName';
static final String accountEmail = 'accountEmail'; static const String accountEmail = 'accountEmail';
static final String dropdownIcon = 'dropdownIcon'; static const String dropdownIcon = 'dropdownIcon';
final TextDirection textDirection; final TextDirection textDirection;

2
packages/flutter/lib/src/rendering/stack.dart
View File

@ -55,7 +55,7 @@ class RelativeRect {
} }
/// A rect that covers the entire container. /// A rect that covers the entire container.
static final RelativeRect fill = const RelativeRect.fromLTRB(0.0, 0.0, 0.0, 0.0); static const RelativeRect fill = const RelativeRect.fromLTRB(0.0, 0.0, 0.0, 0.0);
/// Distance from the left side of the container to the left side of this rectangle. /// Distance from the left side of the container to the left side of this rectangle.
/// ///

8
packages/flutter/lib/src/widgets/widget_inspector.dart
View File

@ -843,10 +843,10 @@ class _InspectorOverlayRenderState {
int get hashCode => hashValues(overlayRect, selected, hashList(candidates), tooltip); int get hashCode => hashValues(overlayRect, selected, hashList(candidates), tooltip);
} }
final int _kMaxTooltipLines = 5; const int _kMaxTooltipLines = 5;
final Color _kTooltipBackgroundColor = const Color.fromARGB(230, 60, 60, 60); const Color _kTooltipBackgroundColor = const Color.fromARGB(230, 60, 60, 60);
final Color _kHighlightedRenderObjectFillColor = const Color.fromARGB(128, 128, 128, 255); const Color _kHighlightedRenderObjectFillColor = const Color.fromARGB(128, 128, 128, 255);
final Color _kHighlightedRenderObjectBorderColor = const Color.fromARGB(128, 64, 64, 128); const Color _kHighlightedRenderObjectBorderColor = const Color.fromARGB(128, 64, 64, 128);
/// A layer that outlines the selected [RenderObject] and candidate render /// A layer that outlines the selected [RenderObject] and candidate render
/// objects that also match the last pointer location. /// objects that also match the last pointer location.

2
packages/flutter/test/widgets/list_view_misc_test.dart
View File

@ -6,7 +6,7 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/rendering.dart'; import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart'; import 'package:flutter/widgets.dart';
final Key blockKey = const Key('test'); const Key blockKey = const Key('test');
void main() { void main() {
testWidgets('Cannot scroll a non-overflowing block', (WidgetTester tester) async { testWidgets('Cannot scroll a non-overflowing block', (WidgetTester tester) async {

134
packages/flutter/test/widgets/multichild_test.dart
View File

@ -37,10 +37,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new DecoratedBox(decoration: kBoxDecorationB), const DecoratedBox(decoration: kBoxDecorationB),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -50,9 +50,9 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -62,10 +62,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB), const DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -75,10 +75,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB), const DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
new DecoratedBox(key: const Key('a'), decoration: kBoxDecorationA), const DecoratedBox(key: const Key('a'), decoration: kBoxDecorationA),
], ],
), ),
); );
@ -88,10 +88,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(key: const Key('a'), decoration: kBoxDecorationA), const DecoratedBox(key: const Key('a'), decoration: kBoxDecorationA),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
new DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB), const DecoratedBox(key: const Key('b'), decoration: kBoxDecorationB),
], ],
), ),
); );
@ -101,8 +101,8 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -122,10 +122,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new DecoratedBox(decoration: kBoxDecorationB), const DecoratedBox(decoration: kBoxDecorationB),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -136,11 +136,11 @@ void main() {
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new Container( new Container(
child: new DecoratedBox(decoration: kBoxDecorationB) child: const DecoratedBox(decoration: kBoxDecorationB)
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -151,13 +151,13 @@ void main() {
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new Container( new Container(
child: new Container( child: new Container(
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -170,13 +170,13 @@ void main() {
children: <Widget>[ children: <Widget>[
new Container( new Container(
child: new Container( child: new Container(
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
), ),
new Container( new Container(
child: new DecoratedBox(decoration: kBoxDecorationA), child: const DecoratedBox(decoration: kBoxDecorationA),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -188,12 +188,12 @@ void main() {
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: <Widget>[
new Container( new Container(
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new Container( new Container(
child: new DecoratedBox(decoration: kBoxDecorationA), child: const DecoratedBox(decoration: kBoxDecorationA),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -206,11 +206,11 @@ void main() {
children: <Widget>[ children: <Widget>[
new Container( new Container(
key: const Key('b'), key: const Key('b'),
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new Container( new Container(
key: const Key('a'), key: const Key('a'),
child: new DecoratedBox(decoration: kBoxDecorationA), child: const DecoratedBox(decoration: kBoxDecorationA),
), ),
], ],
), ),
@ -224,11 +224,11 @@ void main() {
children: <Widget>[ children: <Widget>[
new Container( new Container(
key: const Key('a'), key: const Key('a'),
child: new DecoratedBox(decoration: kBoxDecorationA), child: const DecoratedBox(decoration: kBoxDecorationA),
), ),
new Container( new Container(
key: const Key('b'), key: const Key('b'),
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
], ],
), ),
@ -247,9 +247,9 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new DecoratedBox(decoration: kBoxDecorationB), const DecoratedBox(decoration: kBoxDecorationB),
], ],
), ),
); );
@ -259,12 +259,12 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new FlipWidget( const FlipWidget(
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB), right: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -279,10 +279,10 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new FlipWidget( const FlipWidget(
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB), right: const DecoratedBox(decoration: kBoxDecorationB),
), ),
], ],
), ),
@ -298,11 +298,11 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new FlipWidget( const FlipWidget(
key: const Key('flip'), key: const Key('flip'),
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB), right: const DecoratedBox(decoration: kBoxDecorationB),
), ),
], ],
), ),
@ -311,12 +311,12 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(key: const Key('c'), decoration: kBoxDecorationC), const DecoratedBox(key: const Key('c'), decoration: kBoxDecorationC),
new FlipWidget( const FlipWidget(
key: const Key('flip'), key: const Key('flip'),
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB), right: const DecoratedBox(decoration: kBoxDecorationB),
), ),
], ],
), ),
@ -332,13 +332,13 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new FlipWidget( const FlipWidget(
key: const Key('flip'), key: const Key('flip'),
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB), right: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new DecoratedBox(key: const Key('c'), decoration: kBoxDecorationC), const DecoratedBox(key: const Key('c'), decoration: kBoxDecorationC),
], ],
), ),
); );

38
packages/flutter/test/widgets/parent_data_test.dart
View File

@ -53,14 +53,14 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new DecoratedBox(decoration: kBoxDecorationA), const DecoratedBox(decoration: kBoxDecorationA),
new Positioned( const Positioned(
top: 10.0, top: 10.0,
left: 10.0, left: 10.0,
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -74,18 +74,18 @@ void main() {
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: const <Widget>[
new Positioned( const Positioned(
bottom: 5.0, bottom: 5.0,
right: 7.0, right: 7.0,
child: new DecoratedBox(decoration: kBoxDecorationA), child: const DecoratedBox(decoration: kBoxDecorationA),
), ),
new Positioned( const Positioned(
top: 10.0, top: 10.0,
left: 10.0, left: 10.0,
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
new DecoratedBox(decoration: kBoxDecorationC), const DecoratedBox(decoration: kBoxDecorationC),
], ],
), ),
); );
@ -96,9 +96,9 @@ void main() {
kNonPositioned, kNonPositioned,
]); ]);
final DecoratedBox kDecoratedBoxA = new DecoratedBox(decoration: kBoxDecorationA); final DecoratedBox kDecoratedBoxA = const DecoratedBox(decoration: kBoxDecorationA);
final DecoratedBox kDecoratedBoxB = new DecoratedBox(decoration: kBoxDecorationB); final DecoratedBox kDecoratedBoxB = const DecoratedBox(decoration: kBoxDecorationB);
final DecoratedBox kDecoratedBoxC = new DecoratedBox(decoration: kBoxDecorationC); final DecoratedBox kDecoratedBoxC = const DecoratedBox(decoration: kBoxDecorationC);
await tester.pumpWidget( await tester.pumpWidget(
new Stack( new Stack(
@ -254,13 +254,13 @@ void main() {
new Stack( new Stack(
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
children: <Widget>[ children: <Widget>[
new Positioned( const Positioned(
top: 5.0, top: 5.0,
bottom: 8.0, bottom: 8.0,
child: new Positioned( child: const Positioned(
top: 6.0, top: 6.0,
left: 7.0, left: 7.0,
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
), ),
], ],
@ -276,10 +276,10 @@ void main() {
new Container( new Container(
child: new Row( child: new Row(
children: <Widget>[ children: <Widget>[
new Positioned( const Positioned(
top: 6.0, top: 6.0,
left: 7.0, left: 7.0,
child: new DecoratedBox(decoration: kBoxDecorationB), child: const DecoratedBox(decoration: kBoxDecorationB),
), ),
], ],
), ),

20
packages/flutter/test/widgets/stateful_component_test.dart
View File

@ -22,18 +22,18 @@ void main() {
} }
await tester.pumpWidget( await tester.pumpWidget(
new FlipWidget( const FlipWidget(
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB) right: const DecoratedBox(decoration: kBoxDecorationB)
) )
); );
checkTree(kBoxDecorationA); checkTree(kBoxDecorationA);
await tester.pumpWidget( await tester.pumpWidget(
new FlipWidget( const FlipWidget(
left: new DecoratedBox(decoration: kBoxDecorationB), left: const DecoratedBox(decoration: kBoxDecorationB),
right: new DecoratedBox(decoration: kBoxDecorationA) right: const DecoratedBox(decoration: kBoxDecorationA)
) )
); );
@ -46,9 +46,9 @@ void main() {
checkTree(kBoxDecorationA); checkTree(kBoxDecorationA);
await tester.pumpWidget( await tester.pumpWidget(
new FlipWidget( const FlipWidget(
left: new DecoratedBox(decoration: kBoxDecorationA), left: const DecoratedBox(decoration: kBoxDecorationA),
right: new DecoratedBox(decoration: kBoxDecorationB) right: const DecoratedBox(decoration: kBoxDecorationB)
) )
); );
@ -60,7 +60,7 @@ void main() {
new FlipWidget( new FlipWidget(
key: const Key('rebuild test'), key: const Key('rebuild test'),
left: new TestBuildCounter(), left: new TestBuildCounter(),
right: new DecoratedBox(decoration: kBoxDecorationB) right: const DecoratedBox(decoration: kBoxDecorationB)
) )
); );

8
packages/flutter/test/widgets/test_widgets.dart
View File

@ -6,15 +6,15 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/rendering.dart'; import 'package:flutter/rendering.dart';
import 'package:flutter/widgets.dart'; import 'package:flutter/widgets.dart';
final BoxDecoration kBoxDecorationA = const BoxDecoration( const BoxDecoration kBoxDecorationA = const BoxDecoration(
color: const Color(0xFFFF0000), color: const Color(0xFFFF0000),
); );
final BoxDecoration kBoxDecorationB = const BoxDecoration( const BoxDecoration kBoxDecorationB = const BoxDecoration(
color: const Color(0xFF00FF00), color: const Color(0xFF00FF00),
); );
final BoxDecoration kBoxDecorationC = const BoxDecoration( const BoxDecoration kBoxDecorationC = const BoxDecoration(
color: const Color(0xFF0000FF), color: const Color(0xFF0000FF),
); );
@ -24,7 +24,7 @@ class TestBuildCounter extends StatelessWidget {
@override @override
Widget build(BuildContext context) { Widget build(BuildContext context) {
buildCount += 1; buildCount += 1;
return new DecoratedBox(decoration: kBoxDecorationA); return const DecoratedBox(decoration: kBoxDecorationA);
} }
} }

2
packages/flutter_driver/lib/src/driver/timeline_summary.dart
View File

@ -12,7 +12,7 @@ import 'package:path/path.dart' as path;
import 'common.dart'; import 'common.dart';
import 'timeline.dart'; import 'timeline.dart';
final JsonEncoder _prettyEncoder = const JsonEncoder.withIndent(' '); const JsonEncoder _prettyEncoder = const JsonEncoder.withIndent(' ');
/// The maximum amount of time considered safe to spend for a frame's build /// The maximum amount of time considered safe to spend for a frame's build
/// phase. Anything past that is in the danger of missing the frame as 60FPS. /// phase. Anything past that is in the danger of missing the frame as 60FPS.

4
packages/flutter_test/lib/src/binding.dart
View File

@ -279,7 +279,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
fontSize: 40.0, fontSize: 40.0,
); );
static final Widget _kPreTestMessage = const Center( static const Widget _kPreTestMessage = const Center(
child: const Text( child: const Text(
'Test starting...', 'Test starting...',
style: _kMessageStyle, style: _kMessageStyle,
@ -287,7 +287,7 @@ abstract class TestWidgetsFlutterBinding extends BindingBase
) )
); );
static final Widget _kPostTestMessage = const Center( static const Widget _kPostTestMessage = const Center(
child: const Text( child: const Text(
'Test finished.', 'Test finished.',
style: _kMessageStyle, style: _kMessageStyle,

2
packages/flutter_test/lib/src/finders.dart
View File

@ -15,7 +15,7 @@ typedef bool WidgetPredicate(Widget widget);
typedef bool ElementPredicate(Element element); typedef bool ElementPredicate(Element element);
/// Some frequently used widget [Finder]s. /// Some frequently used widget [Finder]s.
final CommonFinders find = const CommonFinders._(); const CommonFinders find = const CommonFinders._();
/// Provides lightweight syntax for getting frequently used widget [Finder]s. /// Provides lightweight syntax for getting frequently used widget [Finder]s.
/// ///

2
packages/flutter_tools/lib/src/application_package.dart
View File

@ -200,7 +200,7 @@ abstract class IOSApp extends ApplicationPackage {
} }
class BuildableIOSApp extends IOSApp { class BuildableIOSApp extends IOSApp {
static final String kBundleName = 'Runner.app'; static const String kBundleName = 'Runner.app';
BuildableIOSApp({ BuildableIOSApp({
this.appDirectory, this.appDirectory,

6
packages/flutter_tools/lib/src/ios/cocoapods.dart
View File

@ -17,16 +17,16 @@ import '../base/version.dart';
import '../cache.dart'; import '../cache.dart';
import '../globals.dart'; import '../globals.dart';
final String noCocoaPodsConsequence = ''' const String noCocoaPodsConsequence = '''
CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side. CocoaPods is used to retrieve the iOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS. Without resolving iOS dependencies with CocoaPods, plugins will not work on iOS.
For more info, see https://flutter.io/platform-plugins'''; For more info, see https://flutter.io/platform-plugins''';
final String cocoaPodsInstallInstructions = ''' const String cocoaPodsInstallInstructions = '''
brew install cocoapods brew install cocoapods
pod setup'''; pod setup''';
final String cocoaPodsUpgradeInstructions = ''' const String cocoaPodsUpgradeInstructions = '''
brew upgrade cocoapods brew upgrade cocoapods
pod setup'''; pod setup''';

2
packages/flutter_tools/lib/src/vmservice.dart
View File

@ -1025,7 +1025,7 @@ class Isolate extends ServiceObjectOwner {
_updateHeaps(map['_heaps'], mapIsRef); _updateHeaps(map['_heaps'], mapIsRef);
} }
static final int kIsolateReloadBarred = 1005; static const int kIsolateReloadBarred = 1005;
Future<Map<String, dynamic>> reloadSources( Future<Map<String, dynamic>> reloadSources(
{ bool pause: false, { bool pause: false,

2
packages/flutter_tools/test/application_package_test.dart
View File

@ -29,7 +29,7 @@ void main() {
}); });
} }
final String _aaptData = ''' const String _aaptData = '''
package: name='io.flutter.gallery' versionCode='1' versionName='0.0.1' platformBuildVersionName='NMR1' package: name='io.flutter.gallery' versionCode='1' versionName='0.0.1' platformBuildVersionName='NMR1'
sdkVersion:'14' sdkVersion:'14'
targetSdkVersion:'21' targetSdkVersion:'21'