firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "Remove redundant hide handles API from TextSelectionDelegate (#98944)" (#99008)

Browse Source 
This reverts commit 94f6fd6ea8934407452853405835b92fec0d7ad9.
This commit is contained in:
chunhtai 2022-02-23 09:48:53 -08:00 committed by GitHub
parent 85d4b28065
commit 1178c8e9d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/services/text_input.dart
View File

@ -990,6 +990,13 @@ mixin TextSelectionDelegate {
/// updating the text editing state.
void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause);
/// Hides the text selection toolbar.
///
/// By default, hideHandles is true, and the toolbar is hidden along with its
/// handles. If hideHandles is set to false, then the toolbar will be hidden
/// but the handles will remain.
void hideToolbar([bool hideHandles = true]);
/// Brings the provided [TextPosition] into the visible area of the text
/// input.
void bringIntoView(TextPosition position);

6
packages/flutter/lib/src/widgets/editable_text.dart
View File

@ -2908,11 +2908,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
return true;
}
/// Hides the text selection toolbar.
///
/// By default, hideHandles is true, and the toolbar is hidden along with its
/// handles. If hideHandles is set to false, then the toolbar will be hidden
/// but the handles will remain.
@override
void hideToolbar([bool hideHandles = true]) {
if (hideHandles) {
// Hide the handles and the toolbar.

3
packages/flutter/test/rendering/editable_test.dart
View File

@ -27,6 +27,9 @@ class _FakeEditableTextState with TextSelectionDelegate {
@override
TextEditingValue textEditingValue = TextEditingValue.empty;
@override
void hideToolbar([bool hideHandles = true]) { }
@override
void userUpdateTextEditingValue(TextEditingValue value, SelectionChangedCause cause) { }