firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Decrease device discovery timeout from 10 to 5 seconds (#69266)

Browse Source
This commit is contained in:
Jenn Magder 2020-10-28 19:43:19 -07:00 committed by GitHub
parent 46b1b67797
commit 13896b3bd1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dev/devicelab/lib/framework/adb.dart
View File

@ -636,7 +636,7 @@ class IosDeviceDiscovery implements DeviceDiscovery {
Future<List<String>> discoverDevices() async { Future<List<String>> discoverDevices() async {
final List<dynamic> results = json.decode(await eval( final List<dynamic> results = json.decode(await eval(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
<String>['devices', '--machine', '--suppress-analytics', '--device-timeout', '10'], <String>['devices', '--machine', '--suppress-analytics', '--device-timeout', '5'],
)) as List<dynamic>; )) as List<dynamic>;
// [ // [

6
dev/devicelab/lib/framework/utils.dart
View File

@ -434,7 +434,7 @@ Future<String> eval(
List<String> flutterCommandArgs(String command, List<String> options) { List<String> flutterCommandArgs(String command, List<String> options) {
// Commands support the --device-timeout flag. // Commands support the --device-timeout flag.
final List<String> supportedDeviceTimeoutCommands = <String>[ final Set<String> supportedDeviceTimeoutCommands = <String>{
'attach', 'attach',
'devices', 'devices',
'drive', 'drive',
@ -442,13 +442,13 @@ List<String> flutterCommandArgs(String command, List<String> options) {
'logs', 'logs',
'run', 'run',
'screenshot', 'screenshot',
]; };
return <String>[ return <String>[
command, command,
if (deviceOperatingSystem == DeviceOperatingSystem.ios && supportedDeviceTimeoutCommands.contains(command)) if (deviceOperatingSystem == DeviceOperatingSystem.ios && supportedDeviceTimeoutCommands.contains(command))
...<String>[ ...<String>[
'--device-timeout', '--device-timeout',
'10', '5',
], ],
if (localEngine != null) ...<String>['--local-engine', localEngine], if (localEngine != null) ...<String>['--local-engine', localEngine],
if (localEngineSrcPath != null) ...<String>['--local-engine-src-path', localEngineSrcPath], if (localEngineSrcPath != null) ...<String>['--local-engine-src-path', localEngineSrcPath],

2
dev/devicelab/lib/tasks/perf_tests.dart
View File

@ -771,7 +771,7 @@ class PerfTestWithSkSL extends PerfTest {
'run', 'run',
if (deviceOperatingSystem == DeviceOperatingSystem.ios) if (deviceOperatingSystem == DeviceOperatingSystem.ios)
...<String>[ ...<String>[
'--device-timeout', '10', '--device-timeout', '5',
], ],
'--verbose', '--verbose',
'--verbose-system-logs', '--verbose-system-logs',