firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Android] Fix Slider semantics double tap behaviors (flutter/engine#56452)

Browse Source 
## Description

Android fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](https://github.com/flutter/flutter/issues/156427). Similar to [the iOS engine fix](https://github.com/flutter/engine/pull/56427).

Slider widget doesn't define a Semantics.onTap handler, so a double-click while in accessibility mode defaults to a regular tap down event to which _RenderSlider reacts by changing the slider value.

Adding a onTap callback on the framework side was tried in https://github.com/flutter/flutter/pull/157601 but it breaks one accessibility guideline test, see https://github.com/flutter/flutter/pull/157601#discussion_r1821650120). 

See https://github.com/flutter/flutter/pull/157601#discussion_r1829992890 for the reasoning to make the change at the engine level.

## Related Issue

Android fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](https://github.com/flutter/flutter/issues/156427).

## Tests

Adds 1 test.
This commit is contained in:
Bruno Leroux 2024-11-14 18:53:04 +01:00 committed by GitHub
parent a1506e865b
commit 14807a1cb4
2 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
engine/src/flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java
View File

@ -802,6 +802,15 @@ public class AccessibilityBridge extends AccessibilityNodeProvider {
result.addAction(AccessibilityNodeInfo.ACTION_CLICK);
result.setClickable(true);
}
} else {
// Prevent Slider to receive a regular tap which will change the value.
//
// This is needed because it causes slider to select to middle if it
// doesn't have a semantics tap.
if (semanticsNode.hasFlag(Flag.IS_SLIDER)) {
result.addAction(AccessibilityNodeInfo.ACTION_CLICK);
result.setClickable(true);
}
}
if (semanticsNode.hasAction(Action.LONG_PRESS)) {
if (semanticsNode.onLongPressOverride != null) {

15
engine/src/flutter/shell/platform/android/test/io/flutter/view/AccessibilityBridgeTest.java
View File

@ -2165,6 +2165,21 @@ public class AccessibilityBridgeTest {
verify(mockEvent).setSource(eq(mockRootView), eq(123));
}
@Test
public void itAddsClickActionToSliderNodeInfo() {
AccessibilityBridge accessibilityBridge = setUpBridge();
TestSemanticsNode testSemanticsNode = new TestSemanticsNode();
testSemanticsNode.addFlag(AccessibilityBridge.Flag.IS_SLIDER);
TestSemanticsUpdate testSemanticsUpdate = testSemanticsNode.toUpdate();
testSemanticsUpdate.sendUpdateToBridge(accessibilityBridge);
AccessibilityNodeInfo nodeInfo = accessibilityBridge.createAccessibilityNodeInfo(0);
assertEquals(nodeInfo.isClickable(), true);
List<AccessibilityNodeInfo.AccessibilityAction> actions = nodeInfo.getActionList();
assertTrue(actions.contains(AccessibilityNodeInfo.AccessibilityAction.ACTION_CLICK));
}
AccessibilityBridge setUpBridge() {
return setUpBridge(null, null, null, null, null, null);
}