firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] Fix various typos (#162295)

Browse Source
This commit is contained in:
Jason Simmons 2025-01-29 13:38:59 -08:00 committed by GitHub
parent 07ab4ad8b5
commit 14cf4acc97
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
10 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
engine/src/flutter/impeller/core/formats.h
View File

@ -352,13 +352,13 @@ enum class IndexType {
enum class PrimitiveType : uint8_t { enum class PrimitiveType : uint8_t {
/// Draws a triangle for each separate set of three vertices. /// Draws a triangle for each separate set of three vertices.
/// ///
/// Vertices [A, B, C, D, E, F] will produce triages /// Vertices [A, B, C, D, E, F] will produce triangles
/// [ABC, DEF]. /// [ABC, DEF].
kTriangle, kTriangle,
/// Draws a triangle for every adjacent three vertices. /// Draws a triangle for every adjacent three vertices.
/// ///
/// Vertices [A, B, C, D, E, F] will produce triages /// Vertices [A, B, C, D, E, F] will produce triangles
/// [ABC, BCD, CDE, DEF]. /// [ABC, BCD, CDE, DEF].
kTriangleStrip, kTriangleStrip,

2
engine/src/flutter/impeller/display_list/canvas.cc
View File

@ -820,7 +820,7 @@ void Canvas::DrawVertices(const std::shared_ptr<VerticesGeometry>& vertices,
src_coverage = src_coverage =
// Covered by FML_CHECK. // Covered by FML_CHECK.
// NOLINTNEXTLINE(bugprone-unchecked-optional-access) // NOLINTNEXTLINE(bugprone-unchecked-optional-access)
vertices->GetTextureCoordinateCoverge().value_or(cvg.value()); vertices->GetTextureCoordinateCoverage().value_or(cvg.value());
} }
src_contents = src_paint.CreateContents(); src_contents = src_paint.CreateContents();

2
engine/src/flutter/impeller/display_list/dl_vertices_geometry.cc
View File

@ -87,7 +87,7 @@ bool DlVerticesGeometry::HasTextureCoordinates() const {
return vertices_->texture_coordinate_data() != nullptr; return vertices_->texture_coordinate_data() != nullptr;
} }
std::optional<Rect> DlVerticesGeometry::GetTextureCoordinateCoverge() const { std::optional<Rect> DlVerticesGeometry::GetTextureCoordinateCoverage() const {
if (!HasTextureCoordinates()) { if (!HasTextureCoordinates()) {
return std::nullopt; return std::nullopt;
} }

2
engine/src/flutter/impeller/display_list/dl_vertices_geometry.h
View File

@ -37,7 +37,7 @@ class DlVerticesGeometry final : public VerticesGeometry {
bool HasTextureCoordinates() const override; bool HasTextureCoordinates() const override;
std::optional<Rect> GetTextureCoordinateCoverge() const override; std::optional<Rect> GetTextureCoordinateCoverage() const override;
private: private:
PrimitiveType GetPrimitiveType() const; PrimitiveType GetPrimitiveType() const;

2
engine/src/flutter/impeller/entity/geometry/vertices_geometry.h
View File

@ -23,7 +23,7 @@ class VerticesGeometry : public Geometry {
virtual bool HasTextureCoordinates() const = 0; virtual bool HasTextureCoordinates() const = 0;
virtual std::optional<Rect> GetTextureCoordinateCoverge() const = 0; virtual std::optional<Rect> GetTextureCoordinateCoverage() const = 0;
}; };
} // namespace impeller } // namespace impeller

2
engine/src/flutter/impeller/entity/save_layer_utils_unittests.cc
View File

@ -265,7 +265,7 @@ TEST(
} }
TEST(SaveLayerUtilsTest, TEST(SaveLayerUtilsTest,
CoverageLimitRespectedIfSubstantiallyDifferentFromContentCoverge) { CoverageLimitRespectedIfSubstantiallyDifferentFromContentCoverage) {
auto image_filter = FilterContents::MakeMatrixFilter( auto image_filter = FilterContents::MakeMatrixFilter(
FilterInput::Make(Rect()), Matrix::MakeScale({2, 2, 1}), {}); FilterInput::Make(Rect()), Matrix::MakeScale({2, 2, 1}), {});

2
engine/src/flutter/impeller/geometry/path.cc
View File

@ -60,7 +60,7 @@ bool Path::IsEmpty() const {
} }
bool Path::IsSingleContour() const { bool Path::IsSingleContour() const {
return data_->single_countour; return data_->single_contour;
} }
/// Determine required storage for points and indices. /// Determine required storage for points and indices.

2
engine/src/flutter/impeller/geometry/path.h
View File

@ -225,7 +225,7 @@ class Path {
FillType fill = FillType::kNonZero; FillType fill = FillType::kNonZero;
Convexity convexity = Convexity::kUnknown; Convexity convexity = Convexity::kUnknown;
bool single_countour = true; bool single_contour = true;
std::optional<Rect> bounds; std::optional<Rect> bounds;
std::vector<Point> points; std::vector<Point> points;
std::vector<ComponentType> components; std::vector<ComponentType> components;

4
engine/src/flutter/impeller/geometry/path_builder.cc
View File

@ -18,7 +18,7 @@ PathBuilder::~PathBuilder() = default;
Path PathBuilder::CopyPath(FillType fill) { Path PathBuilder::CopyPath(FillType fill) {
prototype_.fill = fill; prototype_.fill = fill;
prototype_.single_countour = prototype_.single_contour =
current_contour_location_ == 0u || current_contour_location_ == 0u ||
(contour_count_ == 2 && (contour_count_ == 2 &&
prototype_.components.back() == Path::ComponentType::kContour); prototype_.components.back() == Path::ComponentType::kContour);
@ -28,7 +28,7 @@ Path PathBuilder::CopyPath(FillType fill) {
Path PathBuilder::TakePath(FillType fill) { Path PathBuilder::TakePath(FillType fill) {
prototype_.fill = fill; prototype_.fill = fill;
UpdateBounds(); UpdateBounds();
prototype_.single_countour = prototype_.single_contour =
current_contour_location_ == 0u || current_contour_location_ == 0u ||
(contour_count_ == 2 && (contour_count_ == 2 &&
prototype_.components.back() == Path::ComponentType::kContour); prototype_.components.back() == Path::ComponentType::kContour);

2
engine/src/flutter/impeller/renderer/backend/gles/render_pass_gles.cc
View File

@ -252,7 +252,7 @@ void RenderPassGLES::ResetGLState(const ProcTableGLES& gl) {
auto status = gl.CheckFramebufferStatus(GL_FRAMEBUFFER); auto status = gl.CheckFramebufferStatus(GL_FRAMEBUFFER);
if (status != GL_FRAMEBUFFER_COMPLETE) { if (status != GL_FRAMEBUFFER_COMPLETE) {
VALIDATION_LOG << "Could not create a complete frambuffer: " VALIDATION_LOG << "Could not create a complete framebuffer: "
<< DebugToFramebufferError(status); << DebugToFramebufferError(status);
return false; return false;
} }