firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix overflow issue caused by a long title/subtitle for the vertical stepper (#61623)

Browse Source
This commit is contained in:
Jimmy Wei 2020-07-17 22:21:03 +01:00 committed by GitHub
parent 30e556ddc5
commit 14dcbb2d84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 58 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/flutter/lib/src/material/stepper.dart
View File

@ -520,9 +520,11 @@ class _StepperState extends State<Stepper> with TickerProviderStateMixin {
_buildLine(!_isLast(index)), _buildLine(!_isLast(index)),
], ],
), ),
Container( Expanded(
margin: const EdgeInsetsDirectional.only(start: 12.0), child: Container(
child: _buildHeaderText(index), margin: const EdgeInsetsDirectional.only(start: 12.0),
child: _buildHeaderText(index),
)
), ),
], ],
), ),

53
packages/flutter/test/material/stepper_test.dart
View File

@ -663,4 +663,57 @@ void main() {
await tester.pump(); await tester.pump();
expect(disabledNode.hasPrimaryFocus, isFalse); expect(disabledNode.hasPrimaryFocus, isFalse);
}); });
testWidgets('Stepper header title should not overflow', (WidgetTester tester) async {
const String longText =
'A long long long long long long long long long long long long text';
await tester.pumpWidget(
MaterialApp(
home: Material(
child: ListView(
children: <Widget>[
Stepper(
steps: const <Step>[
Step(
title: Text(longText),
content: Text('Text content')
),
],
),
],
),
),
),
);
expect(tester.takeException(), isNull);
});
testWidgets('Stepper header subtitle should not overflow', (WidgetTester tester) async {
const String longText =
'A long long long long long long long long long long long long text';
await tester.pumpWidget(
MaterialApp(
home: Material(
child: ListView(
children: <Widget>[
Stepper(
steps: const <Step>[
Step(
title: Text('Regular title'),
subtitle: Text(longText),
content: Text('Text content')
),
],
),
],
),
),
),
);
expect(tester.takeException(), isNull);
});
} }