firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soft transition for the mustcallsuper in Element forgetChild (#49246)

Browse Source
This commit is contained in:
chunhtai 2020-01-22 11:03:01 -08:00 committed by Flutter GitHub Bot
parent 0fffa510fd
commit 14fc0e5ca8
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/flutter/lib/src/widgets/framework.dart
View File

@ -3349,7 +3349,12 @@ abstract class Element extends DiagnosticableTree implements BuildContext {
/// The element will still have a valid parent when this is called. After this /// The element will still have a valid parent when this is called. After this
/// is called, [deactivateChild] is called to sever the link to this object. /// is called, [deactivateChild] is called to sever the link to this object.
@protected @protected
void forgetChild(Element child); void forgetChild(Element child) {
// TODO(chunhtai): Creates empty body for subclass to call super. This will
// enable us to fix internal tests pro-actively for upcoming breaking
// change.
// https://github.com/flutter/flutter/issues/43780.
}
void _activateWithParent(Element parent, dynamic newSlot) { void _activateWithParent(Element parent, dynamic newSlot) {
assert(_debugLifecycleState == _ElementLifecycle.inactive); assert(_debugLifecycleState == _ElementLifecycle.inactive);