firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Properly track mimics that move in the tree

Browse Source 
We weren't telling the new mimicable that we wanted to start mimicing it.
This commit is contained in:
Adam Barth 2015-08-25 15:33:52 -07:00
parent 4923f0cd08
commit 15e8f741fb
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/flutter/lib/widgets/mimic.dart
View File

@ -75,10 +75,7 @@ class Mimic extends GlobalKeyWatcher {
void didUnmount() {
super.didUnmount();
if (_mimicable != null) {
_mimicable.stopMimic();
_mimicable = null;
}
_stopMimic();
}
void didSyncWatchedKey(GlobalKey key, Widget widget) {
@ -91,9 +88,18 @@ class Mimic extends GlobalKeyWatcher {
_setMimicable(null);
}
void _stopMimic() {
if (_mimicable != null) {
_mimicable.stopMimic();
_mimicable = null;
}
}
void _setMimicable(widget) {
if (_mimicable == null && widget != null)
if (_mimicable != widget) {
_stopMimic();
widget.startMimic();
}
setState(() {
_mimicable = widget;
});