firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove add-to-app bitcode warning (#148587)

Browse Source 
Flutter deprecated bitcode in 2022 https://github.com/flutter/flutter/pull/112828, and introduced a warning in #112900 to let add-to-app devs know.

Apps should be migrated by now, remove the outdated warning.
This commit is contained in:
Jenn Magder 2024-05-20 16:52:15 -07:00 committed by GitHub
parent 5890a2fc73
commit 165e535474
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 1 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View File

@ -87,8 +87,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
const String outputDirectoryName = 'flutter-frameworks'; const String outputDirectoryName = 'flutter-frameworks';
await inDirectory(projectDir, () async { await inDirectory(projectDir, () async {
final StringBuffer outputError = StringBuffer(); await flutter(
await evalFlutter(
'build', 'build',
options: <String>[ options: <String>[
'ios-framework', 'ios-framework',
@ -97,11 +96,7 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
'--obfuscate', '--obfuscate',
'--split-debug-info=symbols', '--split-debug-info=symbols',
], ],
stderr: outputError,
); );
if (!outputError.toString().contains('Bitcode support has been deprecated.')) {
throw TaskResult.failure('Missing bitcode deprecation warning');
}
}); });
final String outputPath = path.join(projectDir.path, outputDirectoryName); final String outputPath = path.join(projectDir.path, outputDirectoryName);

4
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View File

@ -330,10 +330,6 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.'); 'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.');
} }
globals.printWarning(
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n'
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.');
return FlutterCommandResult.success(); return FlutterCommandResult.success();
} }