firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rename port to web-port and hostname to web-hostname (#40370)

Browse Source
This commit is contained in:
Jonah Williams 2019-09-12 15:25:03 -07:00 committed by GitHub
parent baa12b3309
commit 1667d0caa4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/flutter_tools/lib/src/commands/run.dart
View File

@ -289,8 +289,8 @@ class RunCommand extends RunCommandBase {
dumpSkpOnShaderCompilation: argResults['dump-skp-on-shader-compilation'], dumpSkpOnShaderCompilation: argResults['dump-skp-on-shader-compilation'],
observatoryPort: observatoryPort, observatoryPort: observatoryPort,
verboseSystemLogs: argResults['verbose-system-logs'], verboseSystemLogs: argResults['verbose-system-logs'],
hostname: featureFlags.isWebEnabled ? argResults['hostname'] : '', hostname: featureFlags.isWebEnabled ? argResults['web-hostname'] : '',
port: featureFlags.isWebEnabled ? argResults['port'] : '', port: featureFlags.isWebEnabled ? argResults['web-port'] : '',
); );
} }
} }

4
packages/flutter_tools/lib/src/runner/flutter_command.dart
View File

@ -133,12 +133,12 @@ abstract class FlutterCommand extends Command<void> {
} }
void usesWebOptions({ bool hide = true }) { void usesWebOptions({ bool hide = true }) {
argParser.addOption('hostname', argParser.addOption('web-hostname',
defaultsTo: 'localhost', defaultsTo: 'localhost',
help: 'The hostname to serve web application on.', help: 'The hostname to serve web application on.',
hide: hide, hide: hide,
); );
argParser.addOption('port', argParser.addOption('web-port',
defaultsTo: null, defaultsTo: null,
help: 'The host port to serve the web application from. If not provided, the tool ' help: 'The host port to serve the web application from. If not provided, the tool '
'will select a random open port on the host.', 'will select a random open port on the host.',