firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Preliminary PR for engine changes for Expanded/Collapsed Submenu button (#131359)

Browse Source 
This PR is to skip some unit tests in order to merging an [engine
change](https://github.com/flutter/engine/pull/43983).
This commit is contained in:
Qun Cheng 2023-07-27 12:23:42 -07:00 committed by GitHub
parent 7e7a0a811a
commit 16826e062b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/test/widgets/custom_painter_test.dart
View File

@ -520,7 +520,7 @@ void _defineTests() {
); );
expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true));
semantics.dispose(); semantics.dispose();
}); }, skip: true); // https://github.com/flutter/flutter/issues/127617
group('diffing', () { group('diffing', () {
testWidgets('complains about duplicate keys', (WidgetTester tester) async { testWidgets('complains about duplicate keys', (WidgetTester tester) async {

2
packages/flutter/test/widgets/semantics_test.dart
View File

@ -706,7 +706,7 @@ void main() {
], ],
); );
expect(semantics, hasSemantics(expectedSemantics, ignoreId: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreId: true));
}); }, skip: true); // https://github.com/flutter/flutter/issues/127617
testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async { testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester); final SemanticsTester semantics = SemanticsTester(tester);