firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-enable debug canvaskit e2e tests. (#151565)

Browse Source 
Now that https://github.com/flutter/engine/pull/53718 is fixed, these tests should be fine.

After this, we should be able to close https://github.com/flutter/flutter/issues/147731
This commit is contained in:
Jackson Gardner 2024-07-11 13:05:53 -07:00 committed by GitHub
parent bc3d2feb9c
commit 17584ab790
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dev/bots/suite_runners/run_web_tests.dart
View File

@ -292,11 +292,6 @@ class WebTestsSuite {
bool expectWriteResponseFile = false, bool expectWriteResponseFile = false,
String expectResponseFileContent = '', String expectResponseFileContent = '',
}) async { }) async {
// TODO(yjbanov): this is temporarily disabled due to https://github.com/flutter/flutter/issues/147731
if (buildMode == 'debug' && renderer == 'canvaskit') {
print('SKIPPED: $target in debug CanvasKit mode due to https://github.com/flutter/flutter/issues/147731');
return;
}
printProgress('${green}Running integration tests $target in $buildMode mode.$reset'); printProgress('${green}Running integration tests $target in $buildMode mode.$reset');
await runCommand( await runCommand(
flutter, flutter,