firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Reverts "Unskip test. (#162106)" (#162122)

Browse Source 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#162106
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: harryterkelsen
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: causing test breakage on web. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/270/infra
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: polina-c
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {yjbanov}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
No description provided.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
This commit is contained in:
auto-submit[bot] 2025-01-23 23:39:46 +00:00 committed by GitHub
parent 787afad5b4
commit 176a7652e1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
engine/src/flutter/lib/web_ui/test/engine/image/image_test.dart
View File

@ -38,7 +38,9 @@ Future<void> testMain() async {
expect(createdImage, image2);
ui.Image.onCreate = null;
});
// TODO(polina-c): unskip the test when bug is fixed:
// https://github.com/flutter/flutter/issues/110599
}, skip: true);
test('dispose() invokes onDispose once', () async {
int onDisposeInvokedCount = 0;
@ -63,7 +65,9 @@ Future<void> testMain() async {
expect(disposedImage, image2);
ui.Image.onDispose = null;
});
// TODO(polina-c): unskip the test when bug is fixed:
// https://github.com/flutter/flutter/issues/110599
}, skip: true);
}
Future<ui.Image> _createImage() => _createPicture().toImage(10, 10);