firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Upload GPU frame times for Impeller on Android/iOS. (#136565)

Browse Source 
These values will be 0 until https://github.com/flutter/engine/pull/46846 and https://github.com/flutter/engine/pull/46796 roll into the framework.
This commit is contained in:
Jonah Williams 2023-10-14 10:09:26 -07:00 committed by GitHub
parent 2963b7460d
commit 1956474409
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
dev/devicelab/lib/tasks/perf_tests.dart
View File

@ -1286,6 +1286,22 @@ class PerfTest {
); );
} }
final bool recordGPU;
switch (deviceOperatingSystem) {
case DeviceOperatingSystem.ios:
recordGPU = true;
case DeviceOperatingSystem.android:
case DeviceOperatingSystem.androidArm:
case DeviceOperatingSystem.androidArm64:
recordGPU = enableImpeller ?? false;
case DeviceOperatingSystem.fake:
case DeviceOperatingSystem.fuchsia:
case DeviceOperatingSystem.linux:
case DeviceOperatingSystem.macos:
case DeviceOperatingSystem.windows:
recordGPU = false;
}
// TODO(liyuqian): Remove isAndroid restriction once // TODO(liyuqian): Remove isAndroid restriction once
// https://github.com/flutter/flutter/issues/61567 is fixed. // https://github.com/flutter/flutter/issues/61567 is fixed.
final bool isAndroid = deviceOperatingSystem == DeviceOperatingSystem.android; final bool isAndroid = deviceOperatingSystem == DeviceOperatingSystem.android;
@ -1321,6 +1337,12 @@ class PerfTest {
if (data['90hz_frame_percentage'] != null) '90hz_frame_percentage', if (data['90hz_frame_percentage'] != null) '90hz_frame_percentage',
if (data['120hz_frame_percentage'] != null) '120hz_frame_percentage', if (data['120hz_frame_percentage'] != null) '120hz_frame_percentage',
if (data['illegal_refresh_rate_frame_count'] != null) 'illegal_refresh_rate_frame_count', if (data['illegal_refresh_rate_frame_count'] != null) 'illegal_refresh_rate_frame_count',
if (recordGPU) ...<String>[
if (data['average_gpu_frame_time'] != null) 'average_gpu_frame_time',
if (data['90th_percentile_gpu_frame_time'] != null) '90th_percentile_gpu_frame_time',
if (data['99th_percentile_gpu_frame_time'] != null) '99th_percentile_gpu_frame_time',
if (data['worst_gpu_frame_time'] != null) 'worst_gpu_frame_time',
]
], ],
); );
}); });