firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Made insetPadding configurable for Date Picker Dialog (#155651)

Browse Source 
This PR adds following properties to the **DatePickerDialog**:
- `insetPadding`
This commit is contained in:
Sarbagya Dhaubanjar 2024-11-01 02:52:08 +05:45 committed by GitHub
parent 5f65bd06c0
commit 19d8fbc6f4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/flutter/lib/src/material/date_picker.dart
View File

@ -334,6 +334,7 @@ class DatePickerDialog extends StatefulWidget {
this.onDatePickerModeChange,
this.switchToInputEntryModeIcon,
this.switchToCalendarEntryModeIcon,
this.insetPadding = const EdgeInsets.symmetric(horizontal: 16.0, vertical: 24.0),
}) : initialDate = initialDate == null ? null : DateUtils.dateOnly(initialDate),
firstDate = DateUtils.dateOnly(firstDate),
lastDate = DateUtils.dateOnly(lastDate),
@ -436,7 +437,6 @@ class DatePickerDialog extends StatefulWidget {
/// Flutter.
final String? restorationId;
/// Called when the [DatePickerDialog] is toggled between
/// [DatePickerEntryMode.calendar],[DatePickerEntryMode.input].
///
@ -451,6 +451,13 @@ class DatePickerDialog extends StatefulWidget {
/// {@macro flutter.material.date_picker.switchToCalendarEntryModeIcon}
final Icon? switchToCalendarEntryModeIcon;
/// The amount of padding added to [MediaQueryData.viewInsets] on the outside
/// of the dialog. This defines the minimum space between the screen's edges
/// and the dialog.
///
/// Defaults to `EdgeInsets.symmetric(horizontal: 16.0, vertical: 24.0)`.
final EdgeInsets insetPadding;
@override
State<DatePickerDialog> createState() => _DatePickerDialogState();
}
@ -520,9 +527,7 @@ class _DatePickerDialogState extends State<DatePickerDialog> with RestorationMix
}
void _handleDateChanged(DateTime date) {
setState(() {
_selectedDate.value = date;
});
setState(() => _selectedDate.value = date);
}
Size _dialogSize(BuildContext context) {
@ -725,7 +730,7 @@ class _DatePickerDialogState extends State<DatePickerDialog> with RestorationMix
shape: useMaterial3
? datePickerTheme.shape ?? defaults.shape
: datePickerTheme.shape ?? dialogTheme.shape ?? defaults.shape,
insetPadding: const EdgeInsets.symmetric(horizontal: 16.0, vertical: 24.0),
insetPadding: widget.insetPadding,
clipBehavior: Clip.antiAlias,
child: AnimatedContainer(
width: dialogSize.width,

16
packages/flutter/test/material/date_picker_test.dart
View File

@ -2181,6 +2181,22 @@ void main() {
});
});
testWidgets('DatePickerDialog with updated insetPadding', (WidgetTester tester) async {
await tester.pumpWidget(MaterialApp(
home: Material(
child: DatePickerDialog(
initialDate: initialDate,
firstDate: firstDate,
lastDate: lastDate,
insetPadding: const EdgeInsets.fromLTRB(10.0, 20.0, 30.0, 40.0),
),
),
));
final Dialog dialog = tester.widget<Dialog>(find.byType(Dialog));
expect(dialog.insetPadding, const EdgeInsets.fromLTRB(10.0, 20.0, 30.0, 40.0));
});
group('Landscape input-only date picker headers use headlineSmall', () {
// Regression test for https://github.com/flutter/flutter/issues/122056