From 1aba3a66f52f14dea418f7bcf26a5d14b8cc25b4 Mon Sep 17 00:00:00 2001 From: hangyu Date: Thu, 30 May 2024 11:34:07 -0700 Subject: [PATCH] [GAR] [a11y] Update text button page in a11y assessment app (#148905) internal: b/317125569 If the text button label contains its role and state, it will be confusing for tester. it will be announced like "xxx button button" : updated screen and label: --- .../lib/use_cases/text_button.dart | 24 ++++++++++++++----- .../test/text_button_test.dart | 3 +-- 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/dev/a11y_assessments/lib/use_cases/text_button.dart b/dev/a11y_assessments/lib/use_cases/text_button.dart index e9f240fa74..ee83bf989f 100644 --- a/dev/a11y_assessments/lib/use_cases/text_button.dart +++ b/dev/a11y_assessments/lib/use_cases/text_button.dart @@ -39,13 +39,25 @@ class MainWidgetState extends State { child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ - TextButton( - onPressed: () { }, - child: const Text('Text button'), + Row( + mainAxisAlignment: MainAxisAlignment.center, + children: [ + const Text('This is a TextButton:'), + TextButton( + onPressed: () { }, + child: const Text('Action'), + ), + ], ), - const TextButton( - onPressed: null, - child: Text('Text button disabled'), + const Row( + mainAxisAlignment: MainAxisAlignment.center, + children: [ + Text('This is a disabled TextButton:'), + TextButton( + onPressed: null, + child: Text('Action'), + ), + ], ), ], ), diff --git a/dev/a11y_assessments/test/text_button_test.dart b/dev/a11y_assessments/test/text_button_test.dart index 31309d5981..e3cbd1e9ae 100644 --- a/dev/a11y_assessments/test/text_button_test.dart +++ b/dev/a11y_assessments/test/text_button_test.dart @@ -10,7 +10,6 @@ import 'test_utils.dart'; void main() { testWidgets('text button can run', (WidgetTester tester) async { await pumpsUseCase(tester, TextButtonUseCase()); - expect(find.text('Text button'), findsOneWidget); - expect(find.text('Text button disabled'), findsOneWidget); + expect(find.text('Action'), findsExactly(2)); }); }