From 1c236d52454fd6c72c9b49b7b06f08c5ba36ec66 Mon Sep 17 00:00:00 2001 From: Siva Annamalai Date: Wed, 31 Jan 2018 10:03:21 -0800 Subject: [PATCH] Fixes in flutter framework code to address the mixin issue raised in https://github.com/dart-lang/sdk/issues/31984 --- packages/flutter/lib/src/rendering/proxy_box.dart | 2 +- packages/flutter/lib/src/widgets/automatic_keep_alive.dart | 4 ++-- packages/flutter/lib/src/widgets/ticker_provider.dart | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/flutter/lib/src/rendering/proxy_box.dart b/packages/flutter/lib/src/rendering/proxy_box.dart index 67f68d3fe9..3b801955d4 100644 --- a/packages/flutter/lib/src/rendering/proxy_box.dart +++ b/packages/flutter/lib/src/rendering/proxy_box.dart @@ -52,7 +52,7 @@ class RenderProxyBox extends RenderBox with RenderObjectWithChildMixin { +abstract class RenderProxyBoxMixin extends RenderBox with RenderObjectWithChildMixin { // This class is intended to be used as a mixin, and should not be // extended directly. factory RenderProxyBoxMixin._() => null; diff --git a/packages/flutter/lib/src/widgets/automatic_keep_alive.dart b/packages/flutter/lib/src/widgets/automatic_keep_alive.dart index 3f04dc2312..ad264d8aa1 100644 --- a/packages/flutter/lib/src/widgets/automatic_keep_alive.dart +++ b/packages/flutter/lib/src/widgets/automatic_keep_alive.dart @@ -299,7 +299,7 @@ class KeepAliveHandle extends ChangeNotifier { /// /// * [AutomaticKeepAlive], which listens to messages from this mixin. /// * [KeepAliveNotification], the notifications sent by this mixin. -abstract class AutomaticKeepAliveClientMixin extends State { +abstract class AutomaticKeepAliveClientMixin extends State { // This class is intended to be used as a mixin, and should not be // extended directly. factory AutomaticKeepAliveClientMixin._() => null; @@ -358,4 +358,4 @@ abstract class AutomaticKeepAliveClientMixin extends State { _ensureKeepAlive(); return null; } -} \ No newline at end of file +} diff --git a/packages/flutter/lib/src/widgets/ticker_provider.dart b/packages/flutter/lib/src/widgets/ticker_provider.dart index 4bb2e93b8f..5449e8f908 100644 --- a/packages/flutter/lib/src/widgets/ticker_provider.dart +++ b/packages/flutter/lib/src/widgets/ticker_provider.dart @@ -73,7 +73,7 @@ class TickerMode extends InheritedWidget { /// This mixin only supports vending a single ticker. If you might have multiple /// [AnimationController] objects over the lifetime of the [State], use a full /// [TickerProviderStateMixin] instead. -abstract class SingleTickerProviderStateMixin extends State implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 +abstract class SingleTickerProviderStateMixin extends State implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 // This class is intended to be used as a mixin, and should not be // extended directly. factory SingleTickerProviderStateMixin._() => null; @@ -155,7 +155,7 @@ abstract class SingleTickerProviderStateMixin extends State implements /// If you only have a single [Ticker] (for example only a single /// [AnimationController]) for the lifetime of your [State], then using a /// [SingleTickerProviderStateMixin] is more efficient. This is the common case. -abstract class TickerProviderStateMixin extends State implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 +abstract class TickerProviderStateMixin extends State implements TickerProvider { // ignore: TYPE_ARGUMENT_NOT_MATCHING_BOUNDS, https://github.com/dart-lang/sdk/issues/25232 // This class is intended to be used as a mixin, and should not be // extended directly. factory TickerProviderStateMixin._() => null; @@ -231,7 +231,7 @@ abstract class TickerProviderStateMixin extends State implements Ticker class _WidgetTicker extends Ticker { _WidgetTicker(TickerCallback onTick, this._creator, { String debugLabel }) : super(onTick, debugLabel: debugLabel); - final TickerProviderStateMixin _creator; + final TickerProviderStateMixin _creator; @override void dispose() {