firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip integration tests that consistently OOM on a Windows platform. (#160368)

Browse Source 
Towards https://github.com/flutter/flutter/issues/157640.

As far as I can tell, these test cases add no value to be running
specifically on Windows (they are testing general tool functionality),
and it's on [Windows specifically that the tests have the most problems
with OOM and
timeout](https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Windows%20tool_integration_tests_2_9).
This commit is contained in:
Matan Lurey 2024-12-16 11:14:58 -08:00 committed by GitHub
parent ad4a1212dc
commit 1c52436853
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
packages/flutter_tools/test/integration.shard/android_plugin_skip_unsupported_test.dart
View File

@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
import 'dart:io';
import 'package:file_testing/file_testing.dart'; import 'package:file_testing/file_testing.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart';
import 'package:flutter_tools/src/cache.dart'; import 'package:flutter_tools/src/cache.dart';
import '../src/common.dart'; import '../src/common.dart';
@ -104,7 +105,7 @@ void main() {
expect(buildApkResult.stderr.toString(), expect(buildApkResult.stderr.toString(),
isNot(contains('Please fix your settings.gradle'))); isNot(contains('Please fix your settings.gradle')));
expect(buildApkResult, const ProcessResultMatcher()); expect(buildApkResult, const ProcessResultMatcher());
}); }, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
test( test(
'skip plugin with android folder if it does not support the Android platform', 'skip plugin with android folder if it does not support the Android platform',
@ -137,7 +138,7 @@ void main() {
'flakes.', 'flakes.',
); );
} }
}); }, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
// TODO(54566): Remove test when issue is resolved. // TODO(54566): Remove test when issue is resolved.
/// Test project with a `settings.gradle` (PluginEach) that apps were created /// Test project with a `settings.gradle` (PluginEach) that apps were created
@ -152,7 +153,7 @@ void main() {
expect(buildApkResult.stderr.toString(), expect(buildApkResult.stderr.toString(),
isNot(contains('Please fix your settings.gradle'))); isNot(contains('Please fix your settings.gradle')));
expect(buildApkResult, const ProcessResultMatcher()); expect(buildApkResult, const ProcessResultMatcher());
}); }, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
// TODO(54566): Remove test when issue is resolved. // TODO(54566): Remove test when issue is resolved.
/// Test project with a `settings.gradle` (PluginEach) that apps were created /// Test project with a `settings.gradle` (PluginEach) that apps were created
@ -168,7 +169,7 @@ void main() {
expect(buildApkResult.stderr.toString(), expect(buildApkResult.stderr.toString(),
isNot(contains('Please fix your settings.gradle'))); isNot(contains('Please fix your settings.gradle')));
expect(buildApkResult, const ProcessResultMatcher()); expect(buildApkResult, const ProcessResultMatcher());
}); }, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
// TODO(54566): Remove test when issue is resolved. // TODO(54566): Remove test when issue is resolved.
/// Test project with a `settings.gradle` (PluginEach) that apps were created /// Test project with a `settings.gradle` (PluginEach) that apps were created
@ -188,7 +189,7 @@ void main() {
const ProcessResultMatcher( const ProcessResultMatcher(
stderrPattern: 'Please fix your settings.gradle'), stderrPattern: 'Please fix your settings.gradle'),
); );
}); }, skip: Platform.isWindows); // https://github.com/flutter/flutter/issues/157640
} }
const String pubspecWithPluginPath = r''' const String pubspecWithPluginPath = r'''