firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Impeller] Don't enable KHR_debug on Angle. (flutter/engine#56601)

Browse Source 
All it does it log the calls and overwhelms the output for no utility.

<img width="651" alt="Screenshot 2024-11-14 at 3 53 54 PM" src="https://github.com/user-attachments/assets/b2de0d71-6263-4f00-94a0-73a5c0d0135d">
This commit is contained in:
Chinmay Garde 2024-11-14 17:33:32 -08:00 committed by GitHub
parent 3c5bf78a62
commit 1c9aa9544f
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
engine/src/flutter/impeller/renderer/backend/gles/description_gles.cc
View File

@ -178,7 +178,10 @@ bool DescriptionGLES::HasExtension(const std::string& ext) const {
}
bool DescriptionGLES::HasDebugExtension() const {
return HasExtension("GL_KHR_debug");
// Angle just logs calls instead of forwarding debug information to the
// backend. This just overwhelms the logs and is of limited use. Disable on
// Angle.
return HasExtension("GL_KHR_debug") && !IsANGLE();
}
} // namespace impeller