firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the _EquationMember.hashCode override

Browse Source 
Since we removed our operator== overload, we can now allow people to put
these in collections again.

Also, turn on two more analyzer lints: avoid_empty_else and hash_and_equals.
This commit is contained in:
Hixie 2016-03-09 15:20:29 -08:00
parent 48fc37f914
commit 1d03522857
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/cassowary/lib/equation_member.dart
View File

@ -24,8 +24,4 @@ abstract class _EquationMember {
Expression operator *(_EquationMember m) => asExpression() * m; Expression operator *(_EquationMember m) => asExpression() * m;
Expression operator /(_EquationMember m) => asExpression() / m; Expression operator /(_EquationMember m) => asExpression() / m;
@override
int get hashCode =>
throw "An equation member is not comparable and cannot be added to collections";
} }

2
packages/flutter_tools/.analysis_options
View File

@ -13,6 +13,7 @@ analyzer:
todo: ignore todo: ignore
linter: linter:
rules: rules:
- avoid_empty_else
- always_declare_return_types - always_declare_return_types
# we'll turn on avoid_as as soon as it doesn't complain about "as dynamic" # we'll turn on avoid_as as soon as it doesn't complain about "as dynamic"
# - avoid_as # - avoid_as
@ -20,6 +21,7 @@ linter:
# sometimes we have no choice (e.g. when matching other platforms) # sometimes we have no choice (e.g. when matching other platforms)
# - constant_identifier_names # - constant_identifier_names
- empty_constructor_bodies - empty_constructor_bodies
- hash_and_equals
# disabled until regexp fix is pulled in (https://github.com/flutter/flutter/pull/1996) # disabled until regexp fix is pulled in (https://github.com/flutter/flutter/pull/1996)
# - library_names # - library_names
- library_prefixes - library_prefixes