firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Un-skip tests that use flutter build apk. (#159231)

Browse Source 
Closes https://github.com/flutter/flutter/issues/158560.

I believe but am not sure as of
https://github.com/flutter/flutter/pull/159170 merging, many process
flakes that were consuming memory and in turn, making Gradle
particularly sensitive to timing out or being killing by the OS for
low-memory, have been rectified.

It is possible there are additional problems, but they aren't visible at
the moment.

I'd like to re-enable these and keep tracking their stability.
This commit is contained in:
Matan Lurey 2024-11-20 17:13:50 -08:00 committed by GitHub
parent 17e38a4b78
commit 1d24fa8f60
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart
View File

@ -223,9 +223,6 @@ void main() {
expectCCompilerIsConfigured(exampleDirectory); expectCCompilerIsConfigured(exampleDirectory);
}); });
}, },
// TODO(matanlurey): Debug why flutter build apk often timesout.
// See https://github.com/flutter/flutter/issues/158560 for details.
skip: buildSubcommand == 'apk' ? 'flutter build apk times out' : false, // Temporary workaround for https://github.com/flutter/flutter/issues/158560.
tags: <String>['flutter-build-apk'], tags: <String>['flutter-build-apk'],
); );
} }

3
packages/flutter_tools/test/integration.shard/isolated/native_assets_without_cbuild_assemble_test.dart
View File

@ -143,9 +143,6 @@ void main(List<String> args) async {
expect(await process.exitCode, 0); expect(await process.exitCode, 0);
},); },);
}, },
// TODO(matanlurey): Debug why flutter build apk often timesout.
// See https://github.com/flutter/flutter/issues/158560 for details.
skip: buildCommand == 'apk' ? 'flutter build apk times out' : false, // Temporary workaround for https://github.com/flutter/flutter/issues/158560.
tags: <String>['flutter-build-apk'], tags: <String>['flutter-build-apk'],
); );
} }