firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add experimental hot reload flag support to flutter tools (#162889)

Browse Source 
Rather than ask users to pass the complicated and long string
`--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc`
we want a simpler flag to enable the new DDC module system/hot reload.

Technically this flag enables the new module system, not necessarily hot
reload directly. But we only expect people to use the flag to enable hot
reload so I've chosen the name based on that.

---------

Co-authored-by: Nate Biggs <natebiggs@google.com>
This commit is contained in:
Nate Biggs 2025-02-10 12:23:47 -05:00 committed by GitHub
parent 33a4c95de0
commit 1d766ed8d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 17 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/flutter_tools/lib/src/runner/flutter_command.dart
View File

@ -151,6 +151,7 @@ abstract final class FlutterOptions {
static const String kWebBrowserFlag = 'web-browser-flag';
static const String kWebResourcesCdnFlag = 'web-resources-cdn';
static const String kWebWasmFlag = 'wasm';
static const String kWebExperimentalHotReload = 'web-experimental-hot-reload';
}
/// flutter command categories for usage.
@ -336,6 +337,11 @@ abstract class FlutterCommand extends Command<void> {
help: 'Enables expression evaluation in the debugger.',
hide: !verboseHelp,
);
argParser.addFlag(
FlutterOptions.kWebExperimentalHotReload,
help: 'Enables new module format that supports hot reload.',
hide: !verboseHelp,
);
argParser.addOption(
'web-launch-url',
help:
@ -1328,6 +1334,12 @@ abstract class FlutterCommand extends Command<void> {
}
}
// TODO(natebiggs): Delete this when new DDC module system is the default.
if (argParser.options.containsKey(FlutterOptions.kWebExperimentalHotReload) &&
boolArg(FlutterOptions.kWebExperimentalHotReload)) {
extraFrontEndOptions.addAll(<String>['--dartdevc-canary', '--dartdevc-module-format=ddc']);
}
String? codeSizeDirectory;
if (argParser.options.containsKey(FlutterOptions.kAnalyzeSize) &&
boolArg(FlutterOptions.kAnalyzeSize)) {

4
packages/flutter_tools/test/web.shard/hot_reload_web_errors_test.dart
View File

@ -11,9 +11,7 @@ import '../src/common.dart';
void main() {
testAll(
chrome: true,
additionalCommandArgs: <String>[
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
],
additionalCommandArgs: <String>['--web-experimental-hot-reload'],
// TODO(srujzs): Remove this custom message once we have the delta inspector emitting the same
// string as the VM.
constClassFieldRemovalErrorMessage: 'Const class cannot remove fields',

7
packages/flutter_tools/test/web.shard/hot_reload_web_test.dart
View File

@ -9,10 +9,5 @@ import '../integration.shard/test_data/hot_reload_test_common.dart';
import '../src/common.dart';
void main() {
testAll(
chrome: true,
additionalCommandArgs: <String>[
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
],
);
testAll(chrome: true, additionalCommandArgs: <String>['--web-experimental-hot-reload']);
}

7
packages/flutter_tools/test/web.shard/hot_reload_with_asset_web_test.dart
View File

@ -9,10 +9,5 @@ import '../integration.shard/test_data/hot_reload_with_asset_test_common.dart';
import '../src/common.dart';
void main() {
testAll(
chrome: true,
additionalCommandArgs: <String>[
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
],
);
testAll(chrome: true, additionalCommandArgs: <String>['--web-experimental-hot-reload']);
}

7
packages/flutter_tools/test/web.shard/stateless_stateful_hot_reload_web_test.dart
View File

@ -9,10 +9,5 @@ import '../integration.shard/test_data/stateless_stateful_hot_reload_test_common
import '../src/common.dart';
void main() {
testAll(
chrome: true,
additionalCommandArgs: <String>[
'--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc',
],
);
testAll(chrome: true, additionalCommandArgs: <String>['--web-experimental-hot-reload']);
}

4
packages/flutter_tools/test/web.shard/test_data/hot_restart_web_test_common.dart
View File

@ -73,9 +73,7 @@ Future<void> _testProject(
late FlutterRunTestDriver flutter;
final List<String> additionalCommandArgs =
useDDCLibraryBundleFormat
? <String>['--extra-front-end-options=--dartdevc-canary,--dartdevc-module-format=ddc']
: <String>[];
useDDCLibraryBundleFormat ? <String>['--web-experimental-hot-reload'] : <String>[];
final String testName =
'Hot restart (index.html: $name)'
'${additionalCommandArgs.isEmpty ? '' : ' with args: $additionalCommandArgs'}';