firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #897 from Hixie/sync-children

Browse Source 
Provide a fast path for MultiChildRenderObjectWrapper.syncRenderObject() when the children lists are identical.
This commit is contained in:
Ian Hickson 2015-08-31 10:36:28 -07:00
commit 1e61314ed5
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/flutter/lib/widgets/framework.dart
View File

@ -998,6 +998,9 @@ abstract class RenderObjectWrapper extends Widget {
// for use by subclasses that manage their children using lists // for use by subclasses that manage their children using lists
void syncChildren(List<Widget> newChildren, List<Widget> oldChildren) { void syncChildren(List<Widget> newChildren, List<Widget> oldChildren) {
assert(newChildren != null);
assert(oldChildren != null);
assert(!identical(newChildren, oldChildren));
// This attempts to diff the new child list (this.children) with // This attempts to diff the new child list (this.children) with
// the old child list (old.children), and update our renderObject // the old child list (old.children), and update our renderObject
@ -1257,7 +1260,19 @@ abstract class MultiChildRenderObjectWrapper extends RenderObjectWrapper {
void syncRenderObject(MultiChildRenderObjectWrapper old) { void syncRenderObject(MultiChildRenderObjectWrapper old) {
super.syncRenderObject(old); super.syncRenderObject(old);
syncChildren(children, old == null ? const <Widget>[] : old.children); List<Widget> oldChildren = old == null ? const <Widget>[] : old.children;
if (oldChildren == children) {
int index = children.length;
Widget nextSibling = null;
while (index > 0) {
index -= 1;
Widget child = children[index];
nextSibling = syncChild(child, child, nextSibling);
children[index] = nextSibling;
}
} else {
syncChildren(children, oldChildren);
}
} }
} }