From 1f0ea173f36cd1d0659ff4e003e572716fb22800 Mon Sep 17 00:00:00 2001 From: Ojan Vafai Date: Wed, 14 Jan 2015 15:14:46 -0800 Subject: [PATCH] Unprefix -webkit-filter and add a pixel test for it. R=abarth@chromium.org Review URL: https://codereview.chromium.org/850103003 --- engine/src/flutter/HACKING.md | 3 ++- .../src/flutter/tests/lowlevel/filters-expected.sky | 13 +++++++++++++ engine/src/flutter/tests/lowlevel/filters.sky | 11 +++++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 engine/src/flutter/tests/lowlevel/filters-expected.sky create mode 100644 engine/src/flutter/tests/lowlevel/filters.sky diff --git a/engine/src/flutter/HACKING.md b/engine/src/flutter/HACKING.md index 442b406f2a..cf62888de6 100644 --- a/engine/src/flutter/HACKING.md +++ b/engine/src/flutter/HACKING.md @@ -54,7 +54,8 @@ uploaded file in the reference. 2. Create an dummy reference file (foo-expected.sky). 3. Run the test (it will fail). 4. Copy the -actual.png file to googlestorage (see below). -5. Put an pointing to your newly uploaded png in the reference file. +5. Put an pointing to your newly uploaded png in the reference file at +http://storage.googleapis.com/mojo/sky-pngs/SHA1_HASH_HERE Copying the file to googlestorage: $ sha1sum ../out/Debug/layout-test-results/framework/flights-app-pixels-actual.png diff --git a/engine/src/flutter/tests/lowlevel/filters-expected.sky b/engine/src/flutter/tests/lowlevel/filters-expected.sky new file mode 100644 index 0000000000..a73b6fa41d --- /dev/null +++ b/engine/src/flutter/tests/lowlevel/filters-expected.sky @@ -0,0 +1,13 @@ + + + + + + + diff --git a/engine/src/flutter/tests/lowlevel/filters.sky b/engine/src/flutter/tests/lowlevel/filters.sky new file mode 100644 index 0000000000..f08f6e927b --- /dev/null +++ b/engine/src/flutter/tests/lowlevel/filters.sky @@ -0,0 +1,11 @@ + + + +
This should be gray and blurred
+ + +