Add link to golden file test docs in the framework gardener guide (#149207)

This also adds a link from the Framework gardener guide.
This commit is contained in:
Loïc Sharma 2024-05-28 16:55:58 -07:00 committed by GitHub
parent 65e3007687
commit 1f4e378de1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions

View File

@ -121,6 +121,9 @@ If there is a new regression not deemed to be noise in a benchmark:
1. Notify the Flutter engine sheriff and Flutter Hackers Discord chats with any issues you file.
If it's noise, accept the benchmark by clicking the checkbox in the triage details popup.
### Handling a Skia gold failure
See the [golden test build breakage] guide.
## Filing an infra ticket
1. Open a [new infra issue].
1. Add a descriptive title. A message like "Add a LUCI builder for linux web engine" or "Debug gallery startup" is much more helpful than "quick request" or "test doesn't work?".
@ -159,6 +162,7 @@ The bulk of communication happens on [Discord].
[Flutter issues]: https://github.com/flutter/flutter/issues
[TESTOWNERS]: https://github.com/flutter/flutter/blob/main/TESTOWNERS
[flutter-hackers]: https://github.com/orgs/flutter/teams/flutter-hackers
[golden test build breakage]: /docs/contributing/testing/Writing-a-golden-file-test-for-package-flutter.md#build-breakage
[new issue]: https://github.com/flutter/flutter/issues/new/choose
[new infra issue]: https://github.com/flutter/flutter/issues/new?template=6_infrastructure.yml

View File

@ -6,4 +6,6 @@ See also:
* https://skia.org/docs/dev/testing/skiagold/
* https://flutter-gold.skia.org/
* https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter
* [Writing a golden file test for package flutter]
[Writing a golden file test for package flutter]: /docs/contributing/testing/Writing-a-golden-file-test-for-package-flutter.md