firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve Material ink effects

Browse Source 
1) Factors InkWell out of Material so that components can use an ink well
   without needing the shadow/level machinery.

2) Makes the ink effect move at a different velocity once the tap has actually
   occurred, converging with the spec. We don't have the right speeds yet, but
   at least we're approaching the right shape.

3) To support (2), added a primaryPointer attribute to GestureEvents to let
   authors coorelate gesturetapdown events with later gesturetap events.

4) To support (2), modernized SplashAnimation to used AnimatedValue and friends.

5) Added more constants to view-configuration.dart that match Android.

I've also removed the cancelling of the ink effect on scroll. The proper way to
do that is to notice that someone in the event chain is listening for
scrollstart and delay the beginning of the ink effect for some period of time.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1019023003
This commit is contained in:
Adam Barth 2015-03-19 11:17:48 -07:00
parent 1cf73be5af
commit 1f625c9665
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
engine/src/flutter/shell/org/domokit/sky/shell/GestureProvider.java
View File

@ -38,9 +38,11 @@ public class GestureProvider implements GestureDetector.OnGestureListener {
} }
private InputEvent createGestureEvent(MotionEvent event) { private InputEvent createGestureEvent(MotionEvent event) {
int pointerIndex = event.getActionIndex();
GestureData gestureData = new GestureData(); GestureData gestureData = new GestureData();
gestureData.x = event.getX(); gestureData.primaryPointer = event.getPointerId(pointerIndex);
gestureData.y = event.getY(); gestureData.x = event.getX(pointerIndex);
gestureData.y = event.getY(pointerIndex);
InputEvent inputEvent = new InputEvent(); InputEvent inputEvent = new InputEvent();
inputEvent.timeStamp = event.getEventTime(); inputEvent.timeStamp = event.getEventTime();
inputEvent.gestureData = gestureData; inputEvent.gestureData = gestureData;

1
engine/src/flutter/shell/ui/input_event_converter.cc
View File

@ -96,6 +96,7 @@ scoped_ptr<blink::WebInputEvent> BuildWebGestureEvent(
} }
if (event->gesture_data) { if (event->gesture_data) {
web_event->primaryPointer = event->gesture_data->primary_pointer;
web_event->x = event->gesture_data->x / device_pixel_ratio; web_event->x = event->gesture_data->x / device_pixel_ratio;
web_event->y = event->gesture_data->y / device_pixel_ratio; web_event->y = event->gesture_data->y / device_pixel_ratio;
} }