From 213f766e35d6594809d01f986cf0805a92f84cdc Mon Sep 17 00:00:00 2001
From: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Date: Mon, 7 Feb 2022 20:00:19 -0800
Subject: [PATCH] Use ValueKey finder instead of text finder in
 keyboard_textfield_test (#97996)

---
 dev/integration_tests/ui/lib/keyboard_textfield.dart     | 9 +++++----
 dev/integration_tests/ui/lib/keys.dart                   | 1 +
 .../ui/test_driver/keyboard_textfield_test.dart          | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/dev/integration_tests/ui/lib/keyboard_textfield.dart b/dev/integration_tests/ui/lib/keyboard_textfield.dart
index 5f3e058cd9..43582b3319 100644
--- a/dev/integration_tests/ui/lib/keyboard_textfield.dart
+++ b/dev/integration_tests/ui/lib/keyboard_textfield.dart
@@ -55,16 +55,17 @@ class _MyHomePageState extends State<MyHomePage> {
 
   @override
   Widget build(BuildContext context) {
-    final String softKeyboardVisibility = MediaQuery.of(context).viewInsets.bottom > 100
-      ? 'keyboard visible'
-      : 'keyboard not visible';
+    final bool isSoftKeyboardVisible = MediaQuery.of(context).viewInsets.bottom > 100;
     return Scaffold(
       body: Column(
         children: <Widget>[
           Text('$offset',
             key: const ValueKey<String>(keys.kOffsetText),
           ),
-          Text(softKeyboardVisibility),
+          if (isSoftKeyboardVisible) const Text(
+            'keyboard visible',
+            key: ValueKey<String>(keys.kKeyboardVisibleView),
+          ),
           Expanded(
             child: ListView(
               key: const ValueKey<String>(keys.kListView),
diff --git a/dev/integration_tests/ui/lib/keys.dart b/dev/integration_tests/ui/lib/keys.dart
index dc2b991256..a69b486bfc 100644
--- a/dev/integration_tests/ui/lib/keys.dart
+++ b/dev/integration_tests/ui/lib/keys.dart
@@ -7,3 +7,4 @@ const String kHeightText = 'height_text';
 const String kUnfocusButton = 'unfocus_button';
 const String kOffsetText = 'offset_text';
 const String kListView = 'list_view';
+const String kKeyboardVisibleView = 'keyboard_visible';
diff --git a/dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart b/dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
index 0c8633ed30..ec1ad5d5b8 100644
--- a/dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
+++ b/dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
@@ -24,7 +24,7 @@ void main() {
       final SerializableFinder listViewFinder = find.byValueKey(keys.kListView);
       final SerializableFinder textFieldFinder = find.byValueKey(keys.kDefaultTextField);
       final SerializableFinder offsetFinder = find.byValueKey(keys.kOffsetText);
-      final SerializableFinder keyboardVisibilityIndicatorFinder = find.text('keyboard visible');
+      final SerializableFinder keyboardVisibilityIndicatorFinder = find.byValueKey(keys.kKeyboardVisibleView);
 
       // Align TextField with bottom edge to ensure it would be covered when keyboard comes up.
       await driver.waitForAbsent(textFieldFinder);