Wire up support for --skia-deterministic-rendering (#14802)

https://github.com/flutter/flutter/issues/14519
This commit is contained in:
Todd Volkert 2018-02-20 23:22:58 -08:00 committed by GitHub
parent 50b7fad6a3
commit 21c514fc56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 16 additions and 1 deletions

View File

@ -1 +1 @@
585610456326bc455ffeb257f6d33d476b4ee3fc ead227f118077d1f2b57842a32abaf105b573b8a

View File

@ -420,6 +420,8 @@ class AndroidDevice extends Device {
cmd.addAll(<String>['--es', 'route', route]); cmd.addAll(<String>['--es', 'route', route]);
if (debuggingOptions.enableSoftwareRendering) if (debuggingOptions.enableSoftwareRendering)
cmd.addAll(<String>['--ez', 'enable-software-rendering', 'true']); cmd.addAll(<String>['--ez', 'enable-software-rendering', 'true']);
if (debuggingOptions.skiaDeterministicRendering)
cmd.addAll(<String>['--ez', 'skia-deterministic-rendering', 'true']);
if (debuggingOptions.traceSkia) if (debuggingOptions.traceSkia)
cmd.addAll(<String>['--ez', 'trace-skia', 'true']); cmd.addAll(<String>['--ez', 'trace-skia', 'true']);
if (debuggingOptions.debuggingEnabled) { if (debuggingOptions.debuggingEnabled) {

View File

@ -90,6 +90,10 @@ class RunCommand extends RunCommandBase {
'when testing Flutter on emulators. By default, Flutter will\n' 'when testing Flutter on emulators. By default, Flutter will\n'
'attempt to either use OpenGL or Vulkan and fall back to software\n' 'attempt to either use OpenGL or Vulkan and fall back to software\n'
'when neither is available.'); 'when neither is available.');
argParser.addFlag('skia-deterministic-rendering',
negatable: false,
help: 'When combined with --enable-software-rendering, provides 100%\n'
'deterministic Skia rendering.');
argParser.addFlag('trace-skia', argParser.addFlag('trace-skia',
negatable: false, negatable: false,
help: 'Enable tracing of Skia code. This is useful when debugging\n' help: 'Enable tracing of Skia code. This is useful when debugging\n'
@ -229,6 +233,7 @@ class RunCommand extends RunCommandBase {
startPaused: argResults['start-paused'], startPaused: argResults['start-paused'],
useTestFonts: argResults['use-test-fonts'], useTestFonts: argResults['use-test-fonts'],
enableSoftwareRendering: argResults['enable-software-rendering'], enableSoftwareRendering: argResults['enable-software-rendering'],
skiaDeterministicRendering: argResults['skia-deterministic-rendering'],
traceSkia: argResults['trace-skia'], traceSkia: argResults['trace-skia'],
observatoryPort: observatoryPort, observatoryPort: observatoryPort,
); );

View File

@ -320,6 +320,7 @@ class DebuggingOptions {
DebuggingOptions.enabled(this.buildInfo, { DebuggingOptions.enabled(this.buildInfo, {
this.startPaused: false, this.startPaused: false,
this.enableSoftwareRendering: false, this.enableSoftwareRendering: false,
this.skiaDeterministicRendering: false,
this.traceSkia: false, this.traceSkia: false,
this.useTestFonts: false, this.useTestFonts: false,
this.observatoryPort, this.observatoryPort,
@ -330,6 +331,7 @@ class DebuggingOptions {
useTestFonts = false, useTestFonts = false,
startPaused = false, startPaused = false,
enableSoftwareRendering = false, enableSoftwareRendering = false,
skiaDeterministicRendering = false,
traceSkia = false, traceSkia = false,
observatoryPort = null; observatoryPort = null;
@ -338,6 +340,7 @@ class DebuggingOptions {
final BuildInfo buildInfo; final BuildInfo buildInfo;
final bool startPaused; final bool startPaused;
final bool enableSoftwareRendering; final bool enableSoftwareRendering;
final bool skiaDeterministicRendering;
final bool traceSkia; final bool traceSkia;
final bool useTestFonts; final bool useTestFonts;
final int observatoryPort; final int observatoryPort;

View File

@ -210,6 +210,9 @@ class IOSDevice extends Device {
if (debuggingOptions.enableSoftwareRendering) if (debuggingOptions.enableSoftwareRendering)
launchArguments.add('--enable-software-rendering'); launchArguments.add('--enable-software-rendering');
if (debuggingOptions.skiaDeterministicRendering)
launchArguments.add('--skia-deterministic-rendering');
if (debuggingOptions.traceSkia) if (debuggingOptions.traceSkia)
launchArguments.add('--trace-skia'); launchArguments.add('--trace-skia');

View File

@ -332,6 +332,8 @@ class IOSSimulator extends Device {
args.add('--enable-checked-mode'); args.add('--enable-checked-mode');
if (debuggingOptions.startPaused) if (debuggingOptions.startPaused)
args.add('--start-paused'); args.add('--start-paused');
if (debuggingOptions.skiaDeterministicRendering)
args.add('--skia-deterministic-rendering');
if (debuggingOptions.useTestFonts) if (debuggingOptions.useTestFonts)
args.add('--use-test-fonts'); args.add('--use-test-fonts');